feat: P3 presentation polish — glyph presets, segmented separators, live preview row - #118
Merged
Merged
Conversation
This was referenced Sep 6, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P3 — presentation polish (spec §5 P3, ratified 39c3a3f)
unicode(default) /nerd(FA PUA icons) /ascii(dumb terminals) — static resolve fromARMORY_FLEET_GLYPHSat module load; invalid value → unicode + one stderr warning; zero consumer call-site churn; per-preset key-parity tests.hint()joins hint-bar segments with the presetfooterSep(│/|); totals strip and intra-row·separators unchanged (normative mockup).running; blank reserved line otherwise; stale ids degrade to blank.stateLineextracted fromliveCardLines(byte-identical, existing pins untouched);bgCardSnapshotlifted from index.ts to rows.ts.Spec: §5 P3 · Tests: per-preset parity,
resolvePresetNametable, hint joins,stateLineparity,previewLinetruth table (933/933, typecheck clean) · Smoke: 3-preset real-pi tour at 140 cols (unicode regression + live preview tick, ascii glyph-free, nerd byte-verified, invalid-env warn-once).Dogfood catches filed during execution: #115 (footer r:Run-new no handler, pre-existing), #116 (widget glued separators, pre-existing), #117 (preview ctx% — RunRecord maxContext follow-up).