Skip to content

0.5.2 lib types break strict consumers (ProviderHeaders string|null vs Record<string,string>) #25

Description

@rz1989s

Summary

@getpipher/vision@0.5.2's shipped lib types fail typecheck in strict downstream consumers. armory-fleet's pnpm typecheck (tsc strict, skipLibCheck default) went red on main with zero local changes after 0.5.2 landed via the ^0.5 range.

Errors (from armory-fleet, lib/delegate.ts)

  • lib/delegate.ts(434,64): error TS2345: Argument of type 'ProviderHeaders | undefined' is not assignable to parameter of type 'Record<string, string> | undefined'. Type 'ProviderHeaders' is not assignable ... 'string | null' is not assignable to type 'string'.

So ProviderHeaders carries string | null values where a Record<string, string> is consumed — the delegate passes it through untyped-narrowed.

Impact

Any consumer with skipLibCheck: false + strict mode goes red the moment 0.5.2 resolves. armory-fleet pinned 0.5.1 exact as an interim gate-restore.

Ask

  1. Fix the ProviderHeaders type (either narrow string | nullstring at the source, or type the call site in delegate.ts to sanitize nulls).
  2. Ship 0.5.3; consumers on ^0.5 pick it up automatically.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions