fix(api): require channel membership to mark a channel read#182
Closed
devitway wants to merge 1 commit into
Closed
fix(api): require channel membership to mark a channel read#182devitway wants to merge 1 commit into
devitway wants to merge 1 commit into
Conversation
markChannelRead wrote a per-user read cursor for an arbitrary channelID (and probed the latest message id via ChannelMessages) without checking that the caller is subscribed — unlike every sibling channel handler (messages, info, readers, ack, send), which gate on IsSubscribed. Add the same 403 guard so a non-member cannot write read-state for, or probe the latest message id of, a channel they are not in. Extend TestChannelRead_RequiresMembership with the mark-read endpoint.
Contributor
Author
|
Closing — this change is incorrect. Leaving |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
markChannelReadwrote a per-user read cursor for an arbitrarychannelID(and probed the latest message id viaChannelMessages) without checking that the caller is subscribed — unlike every sibling channel handler (messages, info, readers, ack, send), which gate onIsSubscribed.Add the same 403 guard so a non-member cannot write read-state for, or probe the latest message id of, a channel they are not in. Extends
TestChannelRead_RequiresMembershipwith the mark-read endpoint.