feat(setup): platform-aware wizard with smart workflow pre-seeding and macOS-only skip#281
Closed
ichoosetoaccept wants to merge 1 commit intogetsentry:mainfrom
Closed
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
ichoosetoaccept
force-pushed
the
feat/setup-platform-selection
branch
from
73b4ceb to
e12b50a
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Introduce platform selection to the setup wizard, recommend workflows per platform, and avoid prompting for a simulator when macOS is the only platform selected. Add helpers and constants (SetupPlatform, PLATFORM_WORKFLOWS, PLATFORM_OPTIONS, infer/derive/filter helpers), a multi-select platform prompt, and make the setup flow platform-aware (seed workflow defaults, filter simulators, preserve platform in sessionDefaults). Add selectionToMcpConfigJson() and a --format mcp-json option to print a ready-to-paste MCP client config JSON block (runSetupWizard supports 'mcp-json' early-exit). Update tests (createPlatformPrompter and four platform-aware cases) and CHANGELOG.md to document the new behavior.
ichoosetoaccept
force-pushed
the
feat/setup-platform-selection
branch
from
e12b50a to
48129b4
Compare
|
This PR has been inactive for 21 days. It will be closed in 7 days if no further activity occurs. Add a comment to keep it open, or apply the |
Collaborator
|
Hi @ichoosetoaccept — thanks for this PR and for kicking off the platform-aware wizard work. We're closing this in favor of a replacement PR from a branch on Your original commit is preserved as the base of the new branch (authorship intact). On top of it we made the following changes during review:
Replacement PR: #365 Closing this one to consolidate review there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #280
Builds on the env var session defaults and
--format mcp-jsonfoundation landed in #272 to add the platform-aware wizard described in #269.What this adds
New
selectPlatformsstep — the first substantive wizard prompt asks which platforms the project targets (macOS, iOS, tvOS, watchOS, visionOS) via multi-select. Previous choices are recovered on re-run fromsessionDefaults.platform,sessionDefaults.simulatorPlatform, or the existing workflow set viainferPlatformsFromExisting.PLATFORM_WORKFLOWSmapping — each platform maps to its recommended workflow set. The workflow selection prompt is pre-seeded with the union of recommended workflows for all selected platforms. Users can still freely adjust.macOS-only guard — when macOS is the only selected platform, both the simulator selection prompt and the device selection prompt are skipped entirely (
isMacOsOnlyguard incollectSetupSelection). StalesimulatorId,simulatorName, anddeviceIdsession defaults are cleaned up from config on save.platformsession default — for single-platform selections,derivePlatformSessionDefaultwritesplatformtosessionDefaultsinconfig.yaml. For multi-platform the key is omitted and any existingplatformvalue is deleted.--format mcp-jsonincludesXCODEBUILDMCP_PLATFORM— when a single platform is selected,XCODEBUILDMCP_PLATFORMis included in the output env block.Changes
src/cli/commands/setup.ts— platform selection,PLATFORM_WORKFLOWS,inferPlatformsFromExisting,filterSimulatorsByPlatforms,derivePlatformSessionDefault, macOS-only guards, mcp-json platform outputsrc/cli/commands/__tests__/setup.test.ts— tests for macOS-only skip, platform env var in mcp-json output, multi-platform handling, platform inference from existing configCHANGELOG.md— new entries under[Unreleased]