Skip to content

ref(service): Classify service errors by kind #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lcian wants to merge 20 commits into
base: main
Choose a base branch
from

improve

fc3ebb5
Select commit
Loading
Failed to load commit list.
Open

ref(service): Classify service errors by kind #493

improve
fc3ebb5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 8, 2026 in 1s

86.94% (-0.28%) compared to 34180eb

View this Pull Request on Codecov

86.94% (-0.28%) compared to 34180eb

Details

Codecov Report

❌ Patch coverage is 19.29825% with 138 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.94%. Comparing base (34180eb) to head (fc3ebb5).

Files with missing lines Patch % Lines
objectstore-service/src/error.rs 4.16% 92 Missing ⚠️
objectstore-service/src/backend/s3_compatible.rs 18.18% 18 Missing ⚠️
objectstore-service/src/backend/gcs.rs 41.17% 10 Missing ⚠️
objectstore-service/src/backend/local_fs.rs 0.00% 10 Missing ⚠️
objectstore-server/src/endpoints/common.rs 28.57% 5 Missing ⚠️
objectstore-service/src/stream.rs 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
- Coverage   87.21%   86.94%   -0.28%     
==========================================
  Files          85       85              
  Lines       13597    13662      +65     
==========================================
+ Hits        11859    11878      +19     
- Misses       1738     1784      +46
Components Coverage Δ
Rust Backend 91.68% <19.29%> (-0.40%) ⬇️
Rust Client 79.70% <ø> (ø)
Python Client 88.51% <ø> (ø)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov