ref: Change as_multipart_upload_backend to borrow instead of Arc#494
Closed
lcian wants to merge 2 commits into
Closed
ref: Change as_multipart_upload_backend to borrow instead of Arc#494lcian wants to merge 2 commits into
lcian wants to merge 2 commits into
Conversation
lcian
commented
Jun 9, 2026
| self.spawn("initiate_multipart", async move { | ||
| inner.initiate_multipart(&id, &metadata).await | ||
| inner | ||
| .as_multipart_upload_backend()? |
Member
Author
There was a problem hiding this comment.
This is the only disadvantage, i.e. we will spawn a task unnecessarily upon every request if the backend doesn't support multipart uploads.
Contributor
There was a problem hiding this comment.
actually, this lets us improve on the previous solution. we used to have to clone before we knew whether multipart was supported. now we don't. you can attempt the borrow without using the result like you did in CountingBackend
i'll incorporate this into my PR
lcian
force-pushed
the
matt/objectstore-cogs-metric
branch
from
a933c60 to
98f3aa7
Compare
lcian
force-pushed
the
lcian/ref/multipart-borrow
branch
from
974bcba to
a1ec106
Compare
matt-codecov
force-pushed
the
matt/objectstore-cogs-metric
branch
from
98f3aa7 to
2d61ae5
Compare
Contributor
|
absorbed into #492 |
An error occurred while trying to automatically change base from
matt/objectstore-cogs-metric
to
main
June 9, 2026 17:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.