Skip to content

chore(cogs): remove redundant "objectstore" from cogs metric name #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matt-codecov merged 1 commit into from
Jun 9, 2026
+10 −10
Merged

chore(cogs): remove redundant "objectstore" from cogs metric name #498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions objectstore-service/src/backend/counting.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//! Defines [`CountingBackend`], a decorator for the [`Backend`] trait that emits Cost of Goods Sold
//! (COGS) compute usage metrics to the `objectstore.cogs.usage` counter.
//! (COGS) compute usage metrics to the `cogs.usage` counter.
//!
//! [`CountingBackend`] is meant to wrap the outer-most [`Backend`] implementation owned by
//! [`StorageService`] so that every tracked backend operation, whether a single-object operation
Expand Down Expand Up @@ -43,13 +43,13 @@ fn usecase_to_appfeature(usecase: &str) -> &'static str {
}
}

/// Increments `objectstore.cogs.usage` by one operation for the given `usecase`.
/// Increments `cogs.usage` by one operation for the given `usecase`.
///
/// Under the hood, `usecase` is converted to the appropriate `app_feature` value expected in our
/// COGS pipeline.
fn count(usecase: &str) {
objectstore_metrics::count!(
"objectstore.cogs.usage" += 1,
"cogs.usage" += 1,
app_feature = usecase_to_appfeature(usecase),
);
}
Expand All @@ -68,7 +68,7 @@ pub struct CountingBackend {
}

impl CountingBackend {
/// Creates a [`CountingBackend`] that wraps `inner` and increments `objectstore.cogs.usage`
/// Creates a [`CountingBackend`] that wraps `inner` and increments `cogs.usage`
/// before delegating operations to it.
pub fn new(inner: Box<dyn Backend>) -> Self {
let inner: Arc<dyn Backend> = Arc::from(inner);
Expand Down Expand Up @@ -244,7 +244,7 @@ mod tests {

let cogs = captured
.iter()
.filter(|m| m.starts_with("objectstore.cogs.usage"))
.filter(|m| m.starts_with("cogs.usage"))
.count();
assert_eq!(
cogs, 4,
Expand All @@ -253,8 +253,8 @@ mod tests {
assert!(
captured
.iter()
.all(|m| !m.starts_with("objectstore.cogs.usage")
|| m == "objectstore.cogs.usage:+1|c|#app_feature:attachments"),
.all(|m| !m.starts_with("cogs.usage")
|| m == "cogs.usage:+1|c|#app_feature:attachments"),
"captured: {captured:?}"
);
}
Expand All @@ -274,7 +274,7 @@ mod tests {
assert_eq!(
captured
.iter()
.filter(|m| m.starts_with("objectstore.cogs.usage"))
.filter(|m| m.starts_with("cogs.usage"))
.count(),
1,
"captured: {captured:?}"
Expand All @@ -294,7 +294,7 @@ mod tests {
assert!(
captured
.iter()
.any(|m| m == "objectstore.cogs.usage:+1|c|#app_feature:shared"),
.any(|m| m == "cogs.usage:+1|c|#app_feature:shared"),
"captured: {captured:?}"
);
}
Expand Down Expand Up @@ -339,7 +339,7 @@ mod tests {
assert_eq!(
captured
.iter()
.filter(|m| m == &"objectstore.cogs.usage:+1|c|#app_feature:attachments")
.filter(|m| m == &"cogs.usage:+1|c|#app_feature:attachments")
.count(),
5,
"expected one count per multipart operation, captured: {captured:?}"
Expand Down
Loading