Skip to content

chore(validation): Remove experimental validation call#1068

Open
wmak wants to merge 1 commit into
mainfrom
wmak/chore/remove-validation-calls
Open

chore(validation): Remove experimental validation call#1068
wmak wants to merge 1 commit into
mainfrom
wmak/chore/remove-validation-calls

Conversation

@wmak

@wmak wmak commented Jun 9, 2026

Copy link
Copy Markdown
Member
  • This endpoint was experimental and we're removing it in favour of a planned validate endpoint that will look at the entire query instead of just the attributes
  • Removing this since currently everyone hitting is just getting a 403 anyways

- This endpoint was experimental and we're removing it in favour of a
  planned validate endpoint that will look at the entire query instead
  of just the attributes
- Removing this since currently everyone hitting is just getting a 403
  anyways
Comment on lines 423 to 428
return null;
}

function formatValidationResults(
validationResults: Record<string, TraceItemAttributeValidationResult>,
): string {
const entries = Object.entries(validationResults);
if (entries.length === 0) {
return "";
}

return `Validated Attributes:
${entries
.map(([attribute, result]) => {
if (result.valid) {
return `- ${attribute}: valid${result.type ? ` (${result.type})` : ""}`;
}
return `- ${attribute}: invalid${result.error ? ` (${result.error})` : ""}`;
})
.join("\n")}
`;
}

/**
* Create a tool for the agent to query available attributes by dataset
* The tool is pre-bound with the API service and organization configured for the appropriate region

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tool inputSchema advertises attributes validation parameter that is never consumed after removing validation logic

The attributes parameter remains in the exported inputSchema with description "Optional exact attribute keys to validate" but its value is destructured and silently ignored in the execute function, so clients/models will supply it expecting validation that no longer occurs. The tool-level description also still claims it can "validate" attributes. Remove the parameter and update the description, or restore validation logic.

Evidence
  • attributes is declared in the tool's Zod parameters schema (utils.ts:466-472) with description "Optional exact attribute keys to validate, such as ['tags[type]', 'span.duration']".
  • In the execute handler (utils.ts:474-480) attributes is destructured from params but is never passed to fetchCustomAttributes (which only receives attributeTypes, substringMatch, query) nor used anywhere in the function body.
  • traceItemType is computed via getTraceItemType(normalizedDataset) but never used, indicating leftover code from the now-removed validation path.
  • The tool-level description still says "Query, filter, and validate available attributes", so the exported wire metadata misrepresents the tool's actual behavior to the model.

Identified by Warden mcp-audit · WDB-XU9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant