chore(validation): Remove experimental validation call#1068
Open
wmak wants to merge 1 commit into
Open
Conversation
wmak
commented
Jun 9, 2026
Member
- This endpoint was experimental and we're removing it in favour of a planned validate endpoint that will look at the entire query instead of just the attributes
- Removing this since currently everyone hitting is just getting a 403 anyways
- This endpoint was experimental and we're removing it in favour of a planned validate endpoint that will look at the entire query instead of just the attributes - Removing this since currently everyone hitting is just getting a 403 anyways
Comment on lines
423
to
428
| return null; | ||
| } | ||
|
|
||
| function formatValidationResults( | ||
| validationResults: Record<string, TraceItemAttributeValidationResult>, | ||
| ): string { | ||
| const entries = Object.entries(validationResults); | ||
| if (entries.length === 0) { | ||
| return ""; | ||
| } | ||
|
|
||
| return `Validated Attributes: | ||
| ${entries | ||
| .map(([attribute, result]) => { | ||
| if (result.valid) { | ||
| return `- ${attribute}: valid${result.type ? ` (${result.type})` : ""}`; | ||
| } | ||
| return `- ${attribute}: invalid${result.error ? ` (${result.error})` : ""}`; | ||
| }) | ||
| .join("\n")} | ||
| `; | ||
| } | ||
|
|
||
| /** | ||
| * Create a tool for the agent to query available attributes by dataset | ||
| * The tool is pre-bound with the API service and organization configured for the appropriate region |
There was a problem hiding this comment.
Tool inputSchema advertises attributes validation parameter that is never consumed after removing validation logic
The attributes parameter remains in the exported inputSchema with description "Optional exact attribute keys to validate" but its value is destructured and silently ignored in the execute function, so clients/models will supply it expecting validation that no longer occurs. The tool-level description also still claims it can "validate" attributes. Remove the parameter and update the description, or restore validation logic.
Evidence
attributesis declared in the tool's Zodparametersschema (utils.ts:466-472) with description"Optional exact attribute keys to validate, such as ['tags[type]', 'span.duration']".- In the
executehandler (utils.ts:474-480)attributesis destructured from params but is never passed tofetchCustomAttributes(which only receivesattributeTypes,substringMatch,query) nor used anywhere in the function body. traceItemTypeis computed viagetTraceItemType(normalizedDataset)but never used, indicating leftover code from the now-removed validation path.- The tool-level
descriptionstill says "Query, filter, and validate available attributes", so the exported wire metadata misrepresents the tool's actual behavior to the model.
Identified by Warden mcp-audit · WDB-XU9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.