Skip to content

fix: Use Ubuntu container #2115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bitsandfoxes wants to merge 3 commits into from
Closed

fix: Use Ubuntu container #2115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22a57b7
container?
bitsandfoxes Apr 16, 2025
e3801ed
no sudo
bitsandfoxes Apr 16, 2025
61d67e1
no more questions
bitsandfoxes Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,15 @@ jobs:
- target: Linux
# Build using older Linux version to preserve sdk compatibility with old GLIBC
# See discussion in https://github.com/getsentry/sentry-unity/issues/1730 for more details
host: ubuntu-20.04
host: ubuntu-latest
container_image: ubuntu:20.04
- target: Windows
host: windows-latest
uses: ./.github/workflows/sdk.yml
with:
target: ${{ matrix.target }}
runsOn: ${{ matrix.host }}
container_image: ${{ matrix.container_image }}

build-unity-sdk:
name: Build Unity SDK
Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/sdk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ on:
target:
required: true
type: string
container_image:
required: false
type: string

env:
DOTNET_CLI_TELEMETRY_OPTOUT: 1
Expand All @@ -15,6 +18,7 @@ env:
jobs:
build:
runs-on: ${{ inputs.runsOn }}
container: ${{ inputs.container_image != '' && format('{0}', inputs.container_image) || null }}
timeout-minutes: 30
steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -50,13 +54,12 @@ jobs:
key: sdk=${{ inputs.target }}-${{ hashFiles('submodules-status', 'package/package.json', 'Directory.Build.targets', 'sdk-static/**') }}

- name: Installing Linux Dependencies
if: ${{ inputs.target == 'Linux' && steps.cache.outputs.cache-hit != 'true' }}
if: ${{ inputs.target == 'Linux'}}
run: |
sudo apt-get update
sudo apt-get install zlib1g-dev libcurl4-openssl-dev libssl-dev
apt-get update
apt-get install -y zlib1g-dev libcurl4-openssl-dev libssl-dev

- name: Build
if: steps.cache.outputs.cache-hit != 'true'
run: |
git submodule update --init --recursive ${{ steps.env.outputs.submodules }}
dotnet msbuild /t:Build${{ inputs.target }}SDK /p:Configuration=Release /p:OutDir=other src/Sentry.Unity
Expand Down
Loading