fix(flamegraph): Only dispatch checkpoint when finishing flamegraph i… #104564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nteraction There seems to be some edge cases where the checkpoint action is dispatched mid interaction and can result in an infinite re-render. This ensures the checkpoint is only emitted when the interaction finishes.
github-actions
bot
added
the
Scope: Frontend
nsdeschenes
approved these changes
Dec 9, 2025
Zylphrex
deleted the
txiao/fix/only-dispatch-checkpoint-when-finishing-flamegraph-interaction
branch
ryan953
pushed a commit
that referenced
this pull request
Dec 9, 2025
#104564) …nteraction There seems to be some edge cases where the checkpoint action is dispatched mid interaction and can result in an infinite re-render. This ensures the checkpoint is only emitted when the interaction finishes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nteraction
There seems to be some edge cases where the checkpoint action is dispatched mid interaction and can result in an infinite re-render. This ensures the checkpoint is only emitted when the interaction finishes.