Skip to content

Conversation

@BYK
Copy link
Member

@BYK BYK commented Jan 16, 2026

Summary

Updates the changelog-preview workflow to use pull_request_target instead of pull_request.

Why?

This change is required for the changelog preview to work correctly with PRs from forks. With pull_request, the workflow runs with a read-only GITHUB_TOKEN which cannot post comments or create statuses on fork PRs.

This aligns with the recommended usage in the craft changelog-preview workflow.

Security Note

This change is safe because the changelog-preview workflow:

  • Downloads the Craft binary from releases (not from the PR)
  • Only reads git metadata and configuration
  • Does not execute any code from the PR

@vercel
Copy link

vercel bot commented Jan 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
spotlightjs Ready Ready Preview, Comment Jan 16, 2026 0:56am

Review with Vercel Agent

@BYK BYK deployed to Preview January 16, 2026 12:55 — with GitHub Actions Active
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026

Codecov Results 📊

❌ Patch coverage is 100.00% with 1348 lines missing coverage.
✅ Project coverage is 76.31%. Comparing base (base) to head (head).

Files with missing lines (31)
File Patch % Lines
event.ts 52.61% ⚠️ 263 Missing
mcp.ts 65.91% ⚠️ 151 Missing
messageBuffer.ts 67.57% ⚠️ 120 Missing
docker-compose.ts 77.33% ⚠️ 85 Missing
utils.ts 31.71% ⚠️ 84 Missing
extras.ts 28.13% ⚠️ 69 Missing
debugLogging.ts 29.47% ⚠️ 67 Missing
utils.ts 75.28% ⚠️ 66 Missing
index.ts 24.59% ⚠️ 46 Missing
cors.ts 91.08% ⚠️ 39 Missing and 1 partials
logs.ts 28.85% ⚠️ 37 Missing
traces.ts 93.10% ⚠️ 33 Missing and 1 partials
userAgent.ts 52.63% ⚠️ 27 Missing
index.ts 80.47% ⚠️ 25 Missing
utils.ts 66.67% ⚠️ 23 Missing
errors.ts 75.53% ⚠️ 23 Missing
JsonViewer.tsx 71.62% ⚠️ 21 Missing
traces.ts 75.86% ⚠️ 21 Missing
processEnvelope.ts 86.67% ⚠️ 18 Missing
eventContainer.ts 78.05% ⚠️ 18 Missing
open.ts 42.86% ⚠️ 16 Missing
CodeViewer.tsx 54.55% ⚠️ 15 Missing
contentType.ts 66.67% ⚠️ 15 Missing
Attachment.tsx 90.00% ⚠️ 12 Missing and 1 partials
helpers.ts 70.27% ⚠️ 11 Missing
streaming.ts 76.09% ⚠️ 11 Missing
ShikiProvider.tsx 54.17% ⚠️ 11 Missing
AnsiText.tsx 91.00% ⚠️ 9 Missing
logger.ts 65.22% ⚠️ 8 Missing
logger.ts 87.50% ⚠️ 4 Missing and 1 partials
profileChunkProcessor.ts 100.00% ⚠️ 1 partials
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    76.31%    76.31%        —%
==========================================
  Files           47        47         —
  Lines         5690      5690         —
  Branches       614       611        -3
==========================================
+ Hits          4342      4342         —
- Misses        1348      1348         —
- Partials         5         5         —

Generated by Codecov Action

@BYK BYK enabled auto-merge (squash) January 16, 2026 12:57
@BYK BYK merged commit 1a4177e into main Jan 16, 2026
22 checks passed
@BYK BYK deleted the chore/changelog-preview-target branch January 16, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants