docs(skills): fix Vercel-only condition-type categorization in rules.md - #272
Merged
Merged
Conversation
The legacy-shape condition-type table listed geo_continent, geo_country_region, and protocol alongside genuinely portable fields, and omitted target_path entirely. Verified against the live translator (mapVercelTypeToUnified / mapUnifiedFieldToCloudflare): none of these 4 have a working mapping out of the legacy shape, same as the 5 already called out as Vercel-only. Moved all 9 into that callout and clarified what actually happens on migration.
|
🎉 This PR is included in version 3.15.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rules.md's legacy-shape condition-type table listedgeo_continent,geo_country_region, andprotocolalongside genuinely portable fields, and omittedtarget_pathentirely.mapVercelTypeToUnified/mapUnifiedFieldToCloudflare, not just the old table): none of these 4 have a working mapping out of the legacy shape — same situation as the 5 fields already called out as "Vercel-only." Moved all 9 into that callout and clarified what actually happens when a rule using one of them gets migrated.FieldTypeinsrc/lib/types/common.ts) was a category error —rules.mdcorrectly documents the legacy Vercel-only shape's own vocabulary (VercelRuleType), not the unified shape'sFieldType.SKILL.mdalready gets that split right; onlyrules.md's internal "which of these are portable" claim was wrong.Related
While verifying this against the live translator, found two real (separately filed, not fixed here — out of scope for a docs PR) Cloudflare translator bugs:
regioncondition silently collides with the unified schema's differently-meaningregionfield, producing a valid-but-semantically-wrong Cloudflare filter with no warning.Test plan
npx prettier --check skills/doorman/references/rules.mdnpx tsxagainst the realvercelToUnified/unifiedToCloudflarefunctions that the 9 reclassified fields do in fact fail to translate (see Vercel region condition silently collides with unified schema's differently-meaning region field on Cloudflare sync #270/8 legacy-only Vercel condition types produce invalid Cloudflare filter syntax with no warning #271 for the transcripts)