Show if song is in playlist#137
Conversation
|
you can run the unit tests with coverage to see the test coverage and identify any areas that are under the 80% thresholds. If under then you will need to expand test coverage. Have you considered the handling off offlinemode in this implementation? A lot of this functionality depends on the server being available so we need to take into account when the app is in offlineMode and adjust the options and data that we show accordingly. translations: you need to complete the base english translations, additional languages will be populated through crowdin afterwards. Adding the english base values will trigger CI to push the changes to crowdin which will then generate the keys for other languages. Where is this visible in the UI? Can you provide some screenshots from your test environment to show visually any new UI surface, this will help with evaluation. Thank you for contributing! |
Summary
This is a feature proposal.
The feature is to see which playlists a song already belongs to before adding it again. This helps users manage duplicates and organize their library more effectively.
This feature is OFF by default to minimize network overhead for users with large libraries.
Changes
fetchAllPlaylistsWithSongstoPlaylistLibraryStore. This method fetches full details for all playlists to build a local map of song IDs.AddToPlaylistSheetto conditionally fetch detailed playlist data.numberOfMatchto determine number of times a song is in a playlist.## Concerns
All the translations are in english. Should the translations be automatically translated or left for later translation ?
Did not fully understand the 80% + coverage requirements for the tests, is the added test enough ?
Testing
npx tsc --noEmitpassesnpx jest --no-coveragepassesRelated Issues
Closes N/A (Feature Request)