Fix gofi build: single binary, pinned to a commit - #2
Open
systemjack wants to merge 1 commit into
Open
Conversation
The image build failed at the gofi step:
stat /home/developer/gofi-src/utilities/gofips: directory not found
Upstream consolidated gofips, gofimac, gofinet, gofidns and gofiuser into one
`gofi` binary -- a BREAKING change still sitting in its CHANGELOG's Unreleased
section -- which deleted ./utilities/gofips and ./utilities/gofimac. Because the
clone tracked the default branch with no pin, that landed in every build the
moment it was pushed.
Builds ./utilities/gofi instead, and pins GOFI_REF to a commit so the next
upstream restructure cannot break the image unannounced. Bump the ref
deliberately. The repo's only tag, v0.1.0, is not a usable pin: it predates the
utilities/ layout entirely and is a flat library at the repo root.
Verified against the pinned tree before rebuilding: utilities/gofi/main.go
declares `package main`, there is no nested go.mod so the root module builds it,
and gofi's `go 1.25.0` requirement is met exactly by the image's GO_VERSION.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image build failed at the gofi step:
Upstream consolidated gofips, gofimac, gofinet, gofidns and gofiuser into one
gofibinary -- a BREAKING change still sitting in its CHANGELOG's Unreleasedsection -- which deleted ./utilities/gofips and ./utilities/gofimac. Because the
clone tracked the default branch with no pin, that landed in every build the
moment it was pushed.
Builds ./utilities/gofi instead, and pins GOFI_REF to a commit so the next
upstream restructure cannot break the image unannounced. Bump the ref
deliberately. The repo's only tag, v0.1.0, is not a usable pin: it predates the
utilities/ layout entirely and is a flat library at the repo root.
Verified against the pinned tree before rebuilding: utilities/gofi/main.go
declares
package main, there is no nested go.mod so the root module builds it,and gofi's
go 1.25.0requirement is met exactly by the image's GO_VERSION.