-
-
Notifications
You must be signed in to change notification settings - Fork 41
feat: bind css classes to slickgrid container #2369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #2369 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 195 195
Lines 23932 23933 +1
Branches 8397 8397
=======================================
+ Hits 23932 23933 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
angular-slickgrid
aurelia-slickgrid
slickgrid-react
slickgrid-vue
@slickgrid-universal/angular-row-detail-plugin
@slickgrid-universal/aurelia-row-detail-plugin
@slickgrid-universal/react-row-detail-plugin
@slickgrid-universal/vue-row-detail-plugin
@slickgrid-universal/binding
@slickgrid-universal/common
@slickgrid-universal/composite-editor-component
@slickgrid-universal/custom-footer-component
@slickgrid-universal/custom-tooltip-plugin
@slickgrid-universal/empty-warning-component
@slickgrid-universal/event-pub-sub
@slickgrid-universal/excel-export
@slickgrid-universal/graphql
@slickgrid-universal/odata
@slickgrid-universal/pagination-component
@slickgrid-universal/pdf-export
@slickgrid-universal/row-detail-view-plugin
@slickgrid-universal/rxjs-observable
@slickgrid-universal/text-export
@slickgrid-universal/utils
@slickgrid-universal/vanilla-bundle
@slickgrid-universal/vanilla-force-bundle
commit: |
good question, the only thing I could think of is to simply add it to the "Getting Started" maybe? Otherwise that would be a grid functionality but that's probably too much to add a doc for just this. Unless we add a new doc for Templates or something and add more template stuff in it as well. Side note the Linting fails with Prettier, you might need to run the |
|
dang it, forgot to run it again. will fix it tomorrow with the doc update |
|
I've just noticed you've switched to OXC away from ESLint. That most likely explains why I suddenly see no warnings in VSCode for formatting issues. I had to update the vscode workspace settings to set the path to prettier. Now at least the autofix by format document works but I still don't see any warnings. Do you have any idea whats necessary besides installing the OXC extension? |
|
yeah I switched from ESLint to oxlint and will soon also switch from Prettier to oxfmt because it's way faster. I thought that installing the oxc extension was the only thing needed but I think it might be caused by the fact that I use a Prettier plugin with oxc, not sure if there's more to configure for it to properly reflect slickgrid-universal/package.json Line 103 in 44d9a52
slickgrid-universal/.prettierrc Line 7 in 44d9a52
you could try to remove the plugin to see if that works better. With the oxc plugin it's a bit faster but not that much, so it's ok to remove it. But anyway, that will all go away when I switch to oxfmt (oxc formatter) Also adding the docs in the styling docs is the perfect spot 👍🏻 |
as discussed, this adds the possibility to bind css classes directly to the container inside the angular-slickgrid component.
In which section would you document this behavior?