-
-
Notifications
You must be signed in to change notification settings - Fork 41
feat(tooltip): add global tooltip observation for non-grid elements #2371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #2371 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 195 195
Lines 23932 23962 +30
Branches 8397 8406 +9
=======================================
+ Hits 23932 23962 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
angular-slickgrid
aurelia-slickgrid
slickgrid-react
slickgrid-vue
@slickgrid-universal/angular-row-detail-plugin
@slickgrid-universal/aurelia-row-detail-plugin
@slickgrid-universal/react-row-detail-plugin
@slickgrid-universal/vue-row-detail-plugin
@slickgrid-universal/binding
@slickgrid-universal/common
@slickgrid-universal/composite-editor-component
@slickgrid-universal/custom-footer-component
@slickgrid-universal/custom-tooltip-plugin
@slickgrid-universal/empty-warning-component
@slickgrid-universal/event-pub-sub
@slickgrid-universal/excel-export
@slickgrid-universal/graphql
@slickgrid-universal/odata
@slickgrid-universal/pagination-component
@slickgrid-universal/pdf-export
@slickgrid-universal/row-detail-view-plugin
@slickgrid-universal/rxjs-observable
@slickgrid-universal/text-export
@slickgrid-universal/utils
@slickgrid-universal/vanilla-bundle
@slickgrid-universal/vanilla-force-bundle
commit: |
|
@zewa666 I found this possible feature to render Tooltip also when outside the grid. Basically I encountered this problem while implementing the upcoming menu slot renderer and in my case I have a So does that PR make sense? I admit that it was vibe coded but I had to tweak it a lot to be closer to what I really wanted. Let me know if that makes sense and if there's anything to change or update... so a quick PR review might be nice before I merge it since I'm sure it might also be useful to you as well. I'm not too sure about the option names, but couldn't think of anything better at the moment |
|
I think you can't call it vibe coding if you review and apply refactorings afterwards, otherwise all my work with Junior devs would be vibe coding as well 🤣 I think this looks solid, the only thing I'm questioning is whether there is a chance for multiple instead of a single container and if we should support that? |
This PR add the possibility for the SlickCustomTooltip plugin to work outside the SlickGrid world. This is not enabled by default since the end user might have separate kind of tooltip plugins outside of the grid. However the user can enable the feature via
observeAllTooltips: trueand we can also target specific elements in the DOM viaobserveTooltipContainer: 'body'('body'is the default and this option won't work without theobserveAllTooltips).This PR was partially vibe coded with copilot's help