Skip to content

Conversation

@pkgdemon
Copy link

@pkgdemon pkgdemon commented Jul 11, 2025

  • This just adds another directory to check to see if we need to remove the live user.
  • Since Gershiwn has /Users/ghostbsd with this included it should determine we need to remove the liveuser and remove it.

Summary by Sourcery

Enhancements:

  • Include /Users/ghostbsd in the live user removal directory checks

@pkgdemon pkgdemon self-assigned this Jul 11, 2025
@pkgdemon pkgdemon requested review from a team as code owners July 11, 2025 15:36
@sourcery-ai
Copy link

sourcery-ai bot commented Jul 11, 2025

Reviewer's Guide

The pull request updates the remove_live_user function to include an additional directory path check for '/Users/ghostbsd', ensuring the live user removal now handles the Gershwin-specific directory layout.

Flow diagram for updated live user removal logic

flowchart TD
    A[Start remove_live_user] --> B{Does /usr/home/ghostbsd exist?}
    B -- Yes --> F[Remove GhostBSD live user]
    B -- No --> C{Does /home/ghostbsd exist?}
    C -- Yes --> F
    C -- No --> D{Does /Users/ghostbsd exist?}
    D -- Yes --> F
    D -- No --> E[Do nothing]
    F --> G[End]
    E --> G
Loading

File-Level Changes

Change Details Files
Extend live user removal directory checks
  • Added '/Users/ghostbsd' to the if-statement conditions
backend/functions-users.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pkgdemon - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Member

@ericbsd ericbsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Development Tracker Jul 11, 2025
@ericbsd ericbsd merged commit 698a973 into master Jul 11, 2025
1 check passed
@ericbsd ericbsd deleted the gershwin-user-support branch July 11, 2025 22:42
@github-project-automation github-project-automation bot moved this from In Progress to Done in Development Tracker Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants