fix: mount global FlashMessage so showMessage toasts render - #6
Merged
Merged
Conversation
showMessage() was called from three places (update check results, download notifications, domain switch) but no <FlashMessage /> was ever mounted, so every toast was silently dropped — the manual update check looked completely dead when already on the latest version. Mount it once in the root layout inside SafeAreaProvider, top-positioned with the status-bar inset so it clears the notch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
showMessage() was called from three places (update check results, download notifications, domain switch) but no was ever mounted, so every toast was silently dropped — the manual update check looked completely dead when already on the latest version. Mount it once in the root layout inside SafeAreaProvider, top-positioned with the status-bar inset so it clears the notch.