Fix/tab screen double bottom inset - #11
Merged
Merged
Conversation
💯 Test Coverage
😎 Tests Results
👀 Tests Details • (56%)
|
Tab screens lost a strip roughly the tab bar's height between content and the bar on devices where the bottom inset is real (e.g. a Pixel C on Android 8.1 with its 3-button navigation bar): the tab bar already positioned itself above the system navigation bar, and the screens' SafeAreaView padded the same bottom inset again as content padding. On gesture-navigation devices the inset is near zero, which is why it went unnoticed there. Rather than splitting the inset policy across five screen files (opting each out of the bottom edge) and react-navigation's internal bar behavior, the fix consolidates it in one place: a wrapper in the tab layout consumes all four safe-area edges, the navigator gets an explicit safeAreaInsets.bottom = 0 (a public option, not a patch — and one that fails as visible layout breakage if library defaults ever shift under an upgrade, never as a silent change), and the tab screens become plain Views with no inset logic at all. The strip under the system navigation bar is painted by the container in the bar's color, and the vendored bar's inset channel — which reads 0 on some older devices — is no longer relied upon. Verified pixel-identical on device (content, bar and label positions unchanged). A future floating tab bar over scrolling content now only edits the tab layout file; full-screen stack screens (post, author, model, tag, category) keep handling their own edges.
ghostcoder42
force-pushed
the
fix/tab-screen-double-bottom-inset
branch
from
September 8, 2026 02:04
1d29542 to
a6659bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.