fix(i18n): localize the library screen - #12
Merged
Merged
Conversation
💯 Test Coverage
😎 Tests Results
👀 Tests Details • (56%)
|
The Library screen (history / downloads / favorites tabs) was fully hardcoded English — including two strings whose translations already existed (history.empty, history.clear_all, favorites.empty) but were never wired. Everything now goes through i18n: tab labels (emoji kept in code, text translated), empty states, the delete-download dialog, the 'By <uploader>' row line, active-download status lines (failed / cancelled / downloading with progress) and their Retry / Cancel buttons. New keys added across all seven languages; common.delete joins the shared vocabulary.
ghostcoder42
force-pushed
the
fix/library-i18n
branch
from
September 8, 2026 02:08
60288b7 to
5820e3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Library screen (history / downloads / favorites tabs) was fully hardcoded English — including two strings whose translations already existed (history.empty, history.clear_all, favorites.empty) but were never wired. Everything now goes through i18n: tab labels (emoji kept in code, text translated), empty states, the delete-download dialog, the 'By ' row line, active-download status lines (failed / cancelled / downloading with progress) and their Retry / Cancel buttons. New keys added across all seven languages; common.delete joins the shared vocabulary.