Skip to content

fix(platform): accept muster's Awaiting Session as a reachable MCPServer #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
QuentinBisson wants to merge 1 commit into from
+4 −1
Closed

fix(platform): accept muster's Awaiting Session as a reachable MCPServer #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/lab/oauthfixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ const (
// server that answered 401 — muster's api.StateAuthRequired, spelled the
// CRD way.
mcpServerStateAuthRequired = "Auth Required"
// A per-session server that no session has signed into yet (muster 5.28+,
// giantswarm/muster#1301): the server answered muster's probe, like Auth Required.
mcpServerStateAwaitingSession = "Awaiting Session"
// mcpServerStateConnected is the state once a session signed in to the
// server and muster holds a connection to it.
mcpServerStateConnected = "Connected"
Expand Down
2 changes: 1 addition & 1 deletion internal/lab/platform.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1107,7 +1107,7 @@ func waitSidecarMCPServers(ctx context.Context, cfg *config.Config, sidecars map
// Connected that a session already signed in. Every downstream the lab
// aggregates is such a server now, so this replaced the plain Connected wait.
func waitMCPServerReachable(name string) error {
return waitMCPServerState(name, mcpServerStateConnected, mcpServerStateAuthRequired)
return waitMCPServerState(name, mcpServerStateConnected, mcpServerStateAuthRequired, mcpServerStateAwaitingSession)
}

// waitMCPServerState polls the MCPServer CR's status.state until it reads one
Expand Down
Loading