Add external-dns-crossplane-resources HelmRelease#1837
Merged
Conversation
Deploy external-dns-crossplane-resources chart to create the AWS IAM role for external-dns Route53 access via Crossplane. This replaces the IAM role previously managed by capa-iam-operator. The App CR follows the same pattern as cilium-crossplane-resources and cert-manager-crossplane-resources, using the shared crossplane-config ConfigMap for cluster-specific values (clusterName, accountID, baseDomain). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The Crossplane IAM Role is named {clusterName}-external-dns, replacing
the {clusterName}-Route53Manager-Role previously created by
capa-iam-operator.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace the App CR template with OCIRepository + HelmRelease pattern, aligning with the ongoing migration in PR #1758. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
weatherhog
changed the title
weatherhog
marked this pull request as ready for review
March 13, 2026 12:04
fiunchinho
reviewed
Mar 17, 2026
Comment on lines
+41
to
+46
| valuesFrom: | ||
| # Created by aws-crossplane-cluster-config-operator once the cluster gets provisioned | ||
| - kind: ConfigMap | ||
| name: {{ printf "%s-crossplane-config" (include "resource.default.name" $) | quote }} | ||
| valuesKey: values | ||
| optional: false |
Member
There was a problem hiding this comment.
Instead of creating a dependency on this ConfigMap (and hence on the controller that creates it), could we inline here the required values? I think we only need three values:
- basedomain:
.Values.global.connectivity.baseDomain - aws account id:
{{ include "aws-account-id" $ }} - cluster name:
{{ include "resource.default.name" $ }}
You can see examples of this approach for other HelmReleases in this repo
Replace valuesFrom referencing the crossplane-config ConfigMap with inline values. This removes the runtime dependency on aws-crossplane-cluster-config-operator since clusterName, accountID, and baseDomain are all available at template time. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AndiDog
reviewed
Apr 7, 2026
AndiDog
left a comment
AndiDog
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but let's wait if we need some other changes due to giantswarm/external-dns-crossplane-resources#35
… external-dns-crossplane-resources - Add _oidc.tpl with aws-oidc-domain helper (domain without https://, China-aware) - Replace inline conditional in cert-manager-crossplane-resources-app.yaml with the helper - Inject oidcDomain and oidcDomains values into external-dns-crossplane-resources HelmRelease
Contributor
|
/run cluster-test-suites |
|
Important Some test suites failed. See the Checks tab for detailed results per suite. Re-run only the failed tests: |
Signed-off-by: Matias Charriere <matias@giantswarm.io>
Signed-off-by: Matias Charriere <matias@giantswarm.io>
Contributor
|
/run cluster-test-suites TARGET_SUITES=./providers/capa/standard |
|
Important Some test suites failed. See the Checks tab for detailed results per suite. Re-run only the failed tests: |
Contributor
|
/run cluster-test-suites TARGET_SUITES=./providers/capa/standard |
AndiDog
approved these changes
Apr 13, 2026
Signed-off-by: Matias Charriere <matias@giantswarm.io>
Contributor
|
There were differences in the rendered Helm template, please check! Output |
Contributor
|
/run cluster-test-suites TARGET_SUITES=./providers/capa/standard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
external-dns-crossplane-resourceschart on CAPA clusterscapa-iam-operator{clusterID}-crossplane-configConfigMap for cluster-specific valuesCompanion PR: giantswarm/external-dns-crossplane-resources#35
Test plan
eks.amazonaws.com/role-arnServiceAccount annotation🤖 Generated with Claude Code