Allow the ability for players to requeue before their match ends - #42
Allow the ability for players to requeue before their match ends#42crescendo-ss wants to merge 4 commits into
Conversation
8b94d05 to
e18e6ba
Compare
|
I feel like the goal of this PR is something that will be quite complicated to achieve. Here are some issues, though there are probably more that I haven't thought of:
bool TryReleasePlayer(Player player, StringBuilder? errorMessage);To implement this method, the TeamVersusMatch.MatchData would need to hold a reference to its parent, TeamVersusMatch.
|
Sometimes there could be a situation where any number of players (up to 6) could be knocked out in a practice and there's a duel ongoing to decide the victor. In that case the 6 players are sort of locked in a state where they must wait for the duel to conclude before starting a new match, which could hypothetically take 20+ minutes. Instead of that, allow players to requeue after they have been KO'd. But this does not bypass the timeout punishment due to dying out too quickly ("reneg").
There's an option to configure a minimum
CooldownPeriodthat they must wait after getting eliminated before they can queue in another match.This change builds upon PR #41
OpenSkill rating updates are applied correctly for any permutation of match ordering finishes in this new scheme.