Merge release/1.9.8 - #39
Merged
Merged
Conversation
Release 1.9.7 # -----BEGIN PGP SIGNATURE----- # # iHUEABYKAB0WIQQP29GNkRRfX7IUJjAAqdyOXpp+AAUCaj1BRQAKCRAAqdyOXpp+ # AIAkAQD+/BJh/mQqFNNRXSA2rCUu47tV2r0FhcVKJvYY90APVQEAyUoYgmy6sq3e # ZJBPmgc4FIIgqE22JcEsyoLun9eMDQE= # =gvua # -----END PGP SIGNATURE----- # gpg: Signature made Thu 25 Jun 2026 11:55:01 PM JST # gpg: using EDDSA key 0FDBD18D91145F5FB214263000A9DC8E5E9A7E00 # gpg: Good signature from "Gildas CHERRUEL <gildas@breizh.org>" [ultimate]
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #39 +/- ##
==========================================
+ Coverage 95.12% 95.14% +0.01%
==========================================
Files 32 32
Lines 1354 1359 +5
==========================================
+ Hits 1288 1293 +5
Misses 65 65
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR merges the release/1.9.8 branch by bumping the library version to 1.9.8, updating Go module dependencies, and expanding the HTTP responseWriter wrapper to expose additional interfaces/behaviors.
Changes:
- Bump
VERSIONfrom1.9.7to1.9.8. - Update Go dependencies in
go.mod/go.sum(notably Google API / gRPC related modules). - Add explicit
Header()andFlush()methods (and aRoundTrip()method) to the HTTPresponseWriter, with updated doc comments.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| version.go | Updates the library/application version string to 1.9.8. |
| logger-http.go | Extends responseWriter with additional methods and associated documentation. |
| go.mod | Bumps several module versions for the release. |
| go.sum | Updates checksums to match the dependency version changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -58,34 +82,50 @@ func (w *responseWriter) Hijack() (net.Conn, *bufio.ReadWriter, error) { | |||
| return nil, nil, errors.Join(errors.New("ResponseWrite does not implement http.Hijaker"), errors.InvalidType.With("responseWriter", "Hijacker")) | |||
Comment on lines
+94
to
+99
| // RoundTrip executes a single HTTP transaction, returning | ||
| // a Response for the provided Request. | ||
| // | ||
| // RoundTrip should not attempt to interpret the response. In | ||
| // particular, RoundTrip must return err == nil if it obtained | ||
| // a response, regardless of the response's HTTP status code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 1.9.8. Do not delete the release branch after the merge.