Merge release/1.10.0 - #40
Conversation
Release 1.9.8 # -----BEGIN PGP SIGNATURE----- # # iHUEABYKAB0WIQQP29GNkRRfX7IUJjAAqdyOXpp+AAUCak0jtwAKCRAAqdyOXpp+ # AG0DAQDPmhjmOJpCwZ6tXE3oOHC9QcgXGUcw5Q7PCBz8nfXyHAD+P+8L5Rp8fFh1 # ZTOTOTX/ftZNCBWb6X3Y5EdDpXOLvQU= # =Hdt0 # -----END PGP SIGNATURE----- # gpg: Signature made Wed 08 Jul 2026 01:05:11 AM JST # gpg: using EDDSA key 0FDBD18D91145F5FB214263000A9DC8E5E9A7E00 # gpg: Good signature from "Gildas CHERRUEL <gildas@breizh.org>" [ultimate]
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40 +/- ##
==========================================
- Coverage 95.13% 95.00% -0.14%
==========================================
Files 31 32 +1
Lines 1358 1060 -298
==========================================
- Hits 1292 1007 -285
+ Misses 65 53 -12
+ Partials 1 0 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟡 Changes recommended
The new import "uuid" appears unresolved within this module (no local package and no module dependency), which is likely to break builds/tests unless the toolchain guarantees that package.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR merges the release/1.10.0 branch, updating the library version and refreshing Go module dependencies, with additional changes around UUID handling in JSON marshaling and HTTP request ID generation.
Changes:
- Bump reported library version to
1.10.0. - Update UUID handling in
Record.MarshalJSON()and associated tests, and change HTTP request ID generation. - Update Go module dependencies and bump the
godirective.
File summaries
| File | Description |
|---|---|
| version.go | Updates the exported VERSION string to 1.10.0. |
| record.go | Adjusts UUID “empty value” filtering logic during JSON marshaling and changes UUID imports. |
| record_test.go | Adds/adjusts tests for marshaling “empty UUID” values using two UUID APIs. |
| logger-http.go | Changes request-id generation to use the newly imported UUID package. |
| go.mod | Bumps minimum Go version and updates dependency versions. |
| go.sum | Updates dependency checksums consistent with go.mod changes. |
Review details
- Files reviewed: 5/6 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "net" | ||
| "net/http" | ||
| "time" | ||
| "uuid" | ||
|
|
||
| "github.com/gildas/go-errors" | ||
| "github.com/google/uuid" | ||
| ) |
There was a problem hiding this comment.
Wrong, in Go 1.27, "uuid" is a standard package library, therefore there is no need to add it in go.mod
| import ( | ||
| "bytes" | ||
| "encoding/json" | ||
| "fmt" | ||
| "maps" | ||
| "strconv" | ||
| "strings" | ||
| "uuid" | ||
|
|
||
| "github.com/gildas/go-errors" | ||
| "github.com/google/uuid" | ||
| googleuuid "github.com/google/uuid" | ||
| ) |
There was a problem hiding this comment.
Wrong, in Go 1.27, "uuid" is a standard package library, therefore there is no need to add it in go.mod
| import ( | ||
| "encoding/json" | ||
| "testing" | ||
|
|
||
| "github.com/google/uuid" | ||
| "github.com/stretchr/testify/suite" | ||
| "uuid" | ||
|
|
||
| "github.com/gildas/go-errors" | ||
| "github.com/gildas/go-logger" | ||
| googleuuid "github.com/google/uuid" | ||
| "github.com/stretchr/testify/suite" | ||
| ) |
There was a problem hiding this comment.
Wrong, in Go 1.27, "uuid" is a standard package library, therefore there is no need to add it in go.mod
| module github.com/gildas/go-logger | ||
|
|
||
| go 1.25.8 | ||
| go 1.27 | ||
|
|
Release 1.10.0. Do not delete the release branch after the merge.