Merged
Conversation
- Bug #1: Silent error swallowing in pipeline (CRITICAL) - Bug #2: fatalError in database initialization (CRITICAL) - Bug #3: Race condition in speech recognition (HIGH) Includes agreed remediation strategies: - RetryQueue actor with exponential backoff for Bug #1 - Database recovery mode with read-only fallback for Bug #2 - Structured concurrency refactor for Bug #3
The claude-code-action@beta requires id-token: write permission to fetch OIDC tokens for GitHub authentication.
gilmanb1
added a commit
that referenced
this pull request
Jan 14, 2026
Bug #1: Silent try? failures - Add RetryQueue actor for database operations with retry logic - Replace silent try? with proper error logging in SortAIPipeline - Add retry policies (default, aggressive, patient) - Queue pending operations for background retry Bug #2: Database init fatalError - Replace fatalError in SortAIDatabase.shared with throwing accessor - Create DatabaseRecoveryService actor for automatic recovery - Add DatabaseState enum for tracking healthy/recovering/unavailable states - Implement integrity checks, VACUUM repair, and backup restoration - Add BackupScheduler for automatic daily backups - Create DatabaseRecoveryView UI for recovery feedback - Add recovery notifications for data loss warnings Bug #3: Speech recognition thread safety - Refactor from callback-based to actor-based SpeechRecognitionWorker - Use structured concurrency (withThrowingTaskGroup) for timeout - Proper task cancellation handling - Eliminate race conditions with actor isolation All 233 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes agreed remediation strategies: