Fix CustomProperties plugin calls renamed in @octokit/plugin-rest-endpoint-methods v17

[breymander]

Summary

Fixes #981.

@octokit/plugin-rest-endpoint-methods v17.0.0 (resolved transitively via octokit@^5 / probot@^14) renamed the repository custom-properties methods as a documented breaking change:

Old (removed)	New (v17)
repos.getCustomPropertiesValues	repos.customPropertiesForReposGetRepositoryValues
repos.createOrUpdateCustomPropertiesValues	repos.customPropertiesForReposCreateOrUpdateRepositoryValues

lib/plugins/custom_properties.js still called the old names, which broke the plugin in three ways:

• Read (find()): paginate(undefined, …) falls back to GET https://api.github.com/ (the API root), so existing property values always read as empty and every configured property diffs as a brand-new addition on every repo, every sync.
• Write (apply mode): every add() fails with …createOrUpdateCustomPropertiesValues is not a function. The error is caught and logged per property, so nothing crashes; custom properties are silently never applied, with one error line per repo per sync cycle.
• Nop mode (PR validation): .endpoint(params) on the undefined method throws synchronously, which escapes Promise.all in Settings.updateRepos and crashes the process, leaving the check-run stuck IN_PROGRESS.

This is the same root cause as #971; the #978 fix patched normalize() but the renamed-method calls remained.

Changes

• Rename the three call sites in lib/plugins/custom_properties.js to the v17 method names
• Update the unit-test mocks in test/unit/lib/plugins/custom_properties.test.js to match

Deliberately kept minimal per the contributing guidelines: no behavior changes beyond restoring the intended API calls. I'm aware #990 rebuilds a broader set of fixes from 2.1.18; this PR just unblocks custom-properties sync in the meantime and should be trivial to carry or drop in that effort.

Verification

• npm run test:unit:ci passes (134 passed, 14 skipped, same as base)
• Confirmed against a live install: on 2.1.21 both old method names are undefined on ProbotOctokit().rest.repos and the two v17 names above are present; request.endpoint(undefined, {owner, repo, per_page}) resolves to GET https://api.github.com/, matching the silent-read failure described in 2.1.21: CustomProperties plugin still crashes — modifyProperty() calls renamed octokit methods #981

Note for maintainers

These endpoint operation IDs have now changed twice upstream. If you'd prefer the plugin to be immune to future renames, I'm happy to switch the calls to raw routes instead (octokit.request('GET /repos/{owner}/{repo}/properties/values') / ('PATCH …')). I went with the .rest namespace here to stay consistent with #949.

[Copilot]

Pull request overview

Restores CustomProperties plugin compatibility with @octokit/plugin-rest-endpoint-methods v17 by updating renamed .rest.repos.* method calls, preventing silent read failures and crashes in nop/validation mode.

Changes:

• Updated CustomProperties.find() to paginate using repos.customPropertiesForReposGetRepositoryValues.
• Updated CustomProperties.modifyProperty() (nop + apply paths) to use repos.customPropertiesForReposCreateOrUpdateRepositoryValues.
• Updated unit test mocks and expectations to match the new Octokit method names.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
lib/plugins/custom_properties.js	Renames Octokit REST endpoint method usages to the v17 operation IDs for repo custom-properties read/write.
test/unit/lib/plugins/custom_properties.test.js	Aligns test mocks and assertions with the renamed Octokit REST endpoint methods.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.