Skip to content

[go] Use types to encode and decode jsonrpc queries #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qmuntal wants to merge 14 commits into
base: main
Choose a base branch
from
+613 −1,060
Open

[go] Use types to encode and decode jsonrpc queries #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4dd00fa
use types to encode and decode jsonrpc queries
qmuntal Feb 4, 2026
94c5f50
Apply suggestions from code review
qmuntal Feb 4, 2026
d00a614
reexport some types
qmuntal Feb 4, 2026
107d545
fix race
qmuntal Feb 4, 2026
55759d7
fix test
qmuntal Feb 4, 2026
76a805b
export PingResponse
qmuntal Feb 5, 2026
35eb092
use SendAndWait instead of GetFinalAssistantMessage
qmuntal Feb 5, 2026
cf2ce07
fix nil access
qmuntal Feb 5, 2026
90c8e9d
fix nil access
qmuntal Feb 5, 2026
668b22f
fix nil access
qmuntal Feb 5, 2026
d2d5dec
fix nil access
qmuntal Feb 5, 2026
101df6f
fix race
qmuntal Feb 5, 2026
51dbf77
Merge branch 'main' of https://github.com/github/copilot-sdk into dev…
qmuntal Feb 5, 2026
d46feaa
remove if
qmuntal Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
653 changes: 135 additions & 518 deletions go/client.go
View file
Open in desktop

Large diffs are not rendered by default.

23 changes: 9 additions & 14 deletions go/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,25 +25,20 @@ func TestClient_HandleToolCallRequest(t *testing.T) {
t.Fatalf("Failed to create session: %v", err)
}

params := map[string]any{
"sessionId": session.SessionID,
"toolCallId": "123",
"toolName": "missing_tool",
"arguments": map[string]any{},
params := toolCallRequest{
SessionID: session.SessionID,
ToolCallID: "123",
ToolName: "missing_tool",
Arguments: map[string]any{},
}
response, _ := client.handleToolCallRequest(params)

result, ok := response["result"].(ToolResult)
if !ok {
t.Fatalf("Expected result to be ToolResult, got %T", response["result"])
if response.Result.ResultType != "failure" {
t.Errorf("Expected resultType to be 'failure', got %q", response.Result.ResultType)
}

if result.ResultType != "failure" {
t.Errorf("Expected resultType to be 'failure', got %q", result.ResultType)
}

if result.Error != "tool 'missing_tool' not supported" {
t.Errorf("Expected error to be \"tool 'missing_tool' not supported\", got %q", result.Error)
if response.Result.Error != "tool 'missing_tool' not supported" {
t.Errorf("Expected error to be \"tool 'missing_tool' not supported\", got %q", response.Result.Error)
}
})
}
Expand Down
3 changes: 3 additions & 0 deletions go/internal/e2e/compaction_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ func TestCompaction(t *testing.T) {
if err != nil {
t.Fatalf("Failed to send verification message: %v", err)
}
if answer == nil {
t.Fatalf("Expected an answer, got nil")
}
if answer.Data.Content == nil || !strings.Contains(strings.ToLower(*answer.Data.Content), "dragon") {
t.Errorf("Expected answer to contain 'dragon', got %v", answer.Data.Content)
}
Expand Down
29 changes: 17 additions & 12 deletions go/internal/e2e/mcp_and_agents_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,15 @@ func TestMCPServers(t *testing.T) {
}

// Simple interaction to verify session works
_, err = session.Send(t.Context(), copilot.MessageOptions{
message, err := session.SendAndWait(t.Context(), copilot.MessageOptions{
Prompt: "What is 2+2?",
})
if err != nil {
t.Fatalf("Failed to send message: %v", err)
}

message, err := testharness.GetFinalAssistantMessage(t.Context(), session)
if err != nil {
t.Fatalf("Failed to get final message: %v", err)
if message == nil {
t.Fatal("Expected a message, got nil")
}

if message.Data.Content == nil || !strings.Contains(*message.Data.Content, "4") {
Expand Down Expand Up @@ -97,6 +96,10 @@ func TestMCPServers(t *testing.T) {
t.Fatalf("Failed to send message: %v", err)
}

if message == nil {
t.Fatalf("Expected a message, got nil")
}

if message.Data.Content == nil || !strings.Contains(*message.Data.Content, "6") {
t.Errorf("Expected message to contain '6', got: %v", message.Data.Content)
}
Expand Down Expand Up @@ -168,16 +171,15 @@ func TestCustomAgents(t *testing.T) {
}

// Simple interaction to verify session works
_, err = session.Send(t.Context(), copilot.MessageOptions{
message, err := session.SendAndWait(t.Context(), copilot.MessageOptions{
Prompt: "What is 5+5?",
})
if err != nil {
t.Fatalf("Failed to send message: %v", err)
}

message, err := testharness.GetFinalAssistantMessage(t.Context(), session)
if err != nil {
t.Fatalf("Failed to get final message: %v", err)
if message == nil {
t.Fatal("Expected a message, got nil")
}

if message.Data.Content == nil || !strings.Contains(*message.Data.Content, "10") {
Expand Down Expand Up @@ -228,6 +230,10 @@ func TestCustomAgents(t *testing.T) {
t.Fatalf("Failed to send message: %v", err)
}

if message == nil {
t.Fatalf("Expected a message, got nil")
}

if message.Data.Content == nil || !strings.Contains(*message.Data.Content, "12") {
t.Errorf("Expected message to contain '12', got: %v", message.Data.Content)
}
Expand Down Expand Up @@ -373,16 +379,15 @@ func TestCombinedConfiguration(t *testing.T) {
t.Error("Expected non-empty session ID")
}

_, err = session.Send(t.Context(), copilot.MessageOptions{
message, err := session.SendAndWait(t.Context(), copilot.MessageOptions{
Prompt: "What is 7+7?",
})
if err != nil {
t.Fatalf("Failed to send message: %v", err)
}

message, err := testharness.GetFinalAssistantMessage(t.Context(), session)
if err != nil {
t.Fatalf("Failed to get final message: %v", err)
if message == nil {
t.Fatalf("Expected a message, got nil")
}

if message.Data.Content == nil || !strings.Contains(*message.Data.Content, "14") {
Expand Down
14 changes: 4 additions & 10 deletions go/internal/e2e/permissions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,18 +134,13 @@ func TestPermissions(t *testing.T) {
t.Fatalf("Failed to write test file: %v", err)
}

_, err = session.Send(t.Context(), copilot.MessageOptions{
_, err = session.SendAndWait(t.Context(), copilot.MessageOptions{
Prompt: "Edit protected.txt and replace 'protected' with 'hacked'.",
})
if err != nil {
t.Fatalf("Failed to send message: %v", err)
}

_, err = testharness.GetFinalAssistantMessage(t.Context(), session)
if err != nil {
t.Fatalf("Failed to get final message: %v", err)
}

// Verify the file was NOT modified
content, err := os.ReadFile(testFile)
if err != nil {
Expand All @@ -165,14 +160,13 @@ func TestPermissions(t *testing.T) {
t.Fatalf("Failed to create session: %v", err)
}

_, err = session.Send(t.Context(), copilot.MessageOptions{Prompt: "What is 2+2?"})
message, err := session.SendAndWait(t.Context(), copilot.MessageOptions{Prompt: "What is 2+2?"})
if err != nil {
t.Fatalf("Failed to send message: %v", err)
}

message, err := testharness.GetFinalAssistantMessage(t.Context(), session)
if err != nil {
t.Fatalf("Failed to get final message: %v", err)
if message == nil {
t.Fatal("Expected a message, got nil")
}

if message.Data.Content == nil || !strings.Contains(*message.Data.Content, "4") {
Expand Down
Loading
Loading