feat: add registry base class and opaque handle concepts#15
Conversation
|
So many deleted lines!!!~~~~~~!!!! While going through the deleted lines, it became clearer to me that we should revisit some of our naming conventions. I believe this makes it a bit clearer what's doing what. |
alexcu2718
left a comment
There was a problem hiding this comment.
Overall a lot more clarity on this.
ALSO SCREW YOU FOR MESSING UP MY NEXT PR YOU KNOW I HATE MERGE CONFLICTS.
rebase than kys. Also thanks cutie |
I think that is probably a good idea for some ambiguous fields. I feel like in this specific instance it's quite clear when one writes something like SpdlogFileConfig.file_path. If we had multiple file paths, which we might in the future, then maybe a rename would be good, but I don't think it should be a hard and fast rule to always prefix class/struct members with something. Not to sure though. |
Implemented the RFC-0001 and RFC-0002 (#11 and #14).
This is implemented in the registry_base.hpp, registry_concepts.hpp, and opaque_handle.hpp all under include/engine.
I still need to properly comment these with DOxygen.
I also update frame registry to use the registry base class and deleted device and instance registry/handles since they are not needed for such low level objects, probably.