Skip to content

feat: implement basic rendering#16

Open
alexcu2718 wants to merge 16 commits into
alex_stufffrom
feat/tri_renderer
Open

feat: implement basic rendering#16
alexcu2718 wants to merge 16 commits into
alex_stufffrom
feat/tri_renderer

Conversation

@alexcu2718

Copy link
Copy Markdown
Collaborator

Testing if CI works

(Honestly, probably gonna break on windows!)

@alexcu2718

Copy link
Copy Markdown
Collaborator Author

WOW IT ACTUALLY WORKED

Comment thread .gitignore
Comment thread src/backend/CMakeLists.txt Outdated
Comment thread src/backend/vulkan/vulkan_context.hpp
@alexcu2718

Copy link
Copy Markdown
Collaborator Author

I LOVE WINDOWS

@gituser12981u2 gituser12981u2 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good modularity and splitting overall. I lik. You can take that to either mean that I like it or that I lick it, but what is really the difference.

Also have you ever engaged in making haute French sauce?

Comment thread include/quark/vk/buffer.hpp Outdated
Comment thread include/quark/vk/buffer.hpp Outdated
Comment thread include/quark/vk/buffer.hpp Outdated
Comment thread src/backend/vulkan/device/buffer.cpp Outdated
Comment thread src/backend/vulkan/device/buffer.cpp Outdated
Comment thread src/backend/vulkan/device/buffer.cpp Outdated
Comment thread include/quark/vk/buffer.hpp Outdated
Comment thread include/quark/vk/buffer.hpp Outdated
Comment thread src/backend/vulkan/device/buffer.cpp
Comment thread include/quark/vk/allocator.hpp Outdated
Comment thread include/quark/vk/allocator.hpp Outdated
Comment thread src/backend/vulkan/device/allocator.cpp Outdated

@gituser12981u2 gituser12981u2 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants