gh-1158: Add CosmologyWithGrowthFactor protocol#1163
Open
paddyroddy wants to merge 1 commit into
Open
Conversation
paddyroddy
added
enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates GLASS’s cosmology typing to make the growth factor optional in the core Cosmology protocol, while still requiring it where it’s actually needed (the internal _kappa_ia_nla() intrinsic-alignment computation).
Changes:
- Removed
HasGrowthFactorfrom the baseCosmologyprotocol and introduced aCosmologyWithGrowthFactorprotocol for the stricter requirement. - Updated
_kappa_ia_nla()to acceptCosmologyWithGrowthFactorand clarified the parameter documentation accordingly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
glass/galaxies.py |
Narrows _kappa_ia_nla()’s cosmology type requirement to CosmologyWithGrowthFactor and updates the docstring. |
glass/cosmology.py |
Removes growth factor from Cosmology and adds a new CosmologyWithGrowthFactor protocol. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
connoraird
reviewed
Jul 9, 2026
connoraird
left a comment
connoraird
left a comment
Contributor
There was a problem hiding this comment.
_kappa_ia_nla isn't used in the repo and has been hidden. Can we instead just delete it and remove the growth factor from the Cosmology interface?
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
CosmologyWithGrowthFactorprotocol asgrowth_factorisn't used that often.Closes: #1158
Changelog entry
Added: A
CosmologyWithGrowthFactorprotocolChecks