Merged
Conversation
travis-hoover-glean
approved these changes
Nov 14, 2025
Member
|
Can you run the generation locally to see if this breaks generation output (or makes a breaking change)? |
| moduleName: glean.api_client | ||
| outputModelSuffix: output | ||
| packageManager: poetry | ||
| packageName: glean |
Member
Author
There was a problem hiding this comment.
This causes the generated package name to be wrong. Looking into how to fix this.
Member
Author
There was a problem hiding this comment.
There's a separate packageName under publishing, which is what we want.
The GitHub releases point to https://pypi.org/project/glean But the project is actually glean-api-client Update the package name in speakeasy config to fix this.
david-hamilton-glean
force-pushed
the
hjdivad/fix-speakeasy-release-links
branch
from
f1c68c8 to
d11f630
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitHub releases point to https://pypi.org/project/glean But the project is actually glean-api-client
Update the package name in speakeasy config to fix this.