Skip to content

feat(api): update clientNeedsMcpRemote#91

Merged
david-hamilton-glean merged 1 commit intomainfrom
hjdivad/dcr/c
Jan 21, 2026
Merged

feat(api): update clientNeedsMcpRemote#91
david-hamilton-glean merged 1 commit intomainfrom
hjdivad/dcr/c

Conversation

@david-hamilton-glean
Copy link
Member

@david-hamilton-glean david-hamilton-glean commented Jan 21, 2026

Callers can now call clientNeedsMcpRemote(id, {auth: 'oauth:dcr'}). This will now return false for clients that support http but not oauth DCR.

see also:

@david-hamilton-glean david-hamilton-glean requested a review from a team as a code owner January 21, 2026 23:26
Copy link
Member

@rwjblue-glean rwjblue-glean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the PR description:

Callers can now call clientNeedsMcpRemote(id, {auth: 'oauth-dcr'})

It should be:

clientNeedsMcpRemote(id, {auth: 'oauth:dcr'})

Note: the actual code is right, I just noticed the discrepancy between the two and dug into what the source of truth was (it's oauth:dcr).

@david-hamilton-glean
Copy link
Member Author

From the PR description:

Callers can now call clientNeedsMcpRemote(id, {auth: 'oauth-dcr'})

It should be:

clientNeedsMcpRemote(id, {auth: 'oauth:dcr'})

Note: the actual code is right, I just noticed the discrepancy between the two and dug into what the source of truth was (it's oauth:dcr).

you can thank #90 (comment)

Callers can now call `clientNeedsMcpRemote(id, {auth: 'oauth:dcr'})`.
This will now return false for clients that support http but not oauth
DCR.
@david-hamilton-glean david-hamilton-glean merged commit fd50378 into main Jan 21, 2026
3 checks passed
@david-hamilton-glean david-hamilton-glean deleted the hjdivad/dcr/c branch January 21, 2026 23:55
@david-hamilton-glean david-hamilton-glean added the enhancement New feature or request label Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants