Skip to content

Refactor: Re-use build_movies for watchlist_movies #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glensc merged 2 commits into from
Jul 9, 2026
Merged

Refactor: Re-use build_movies for watchlist_movies #124

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d28e5a4
Re-use build_movies for watchlist_movies
glensc Jul 9, 2026
b840214
Improve variable name in _build_movies
glensc Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions trakt/users.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,11 +457,7 @@ def watchlist_movies(self):
data = paginate('users/{username}/watchlist/movies',
username=slugify(self.username),
)
self._movie_watchlist = []
for movie in data:
mov = movie.pop('movie')
mov.update(movie)
self._movie_watchlist.append(Movie(**mov))
self._movie_watchlist = self._build_movies(data or [])
return self._movie_watchlist

@property
Expand Down Expand Up @@ -515,12 +511,12 @@ def _build_movies(data):
:param data: List of raw movie dicts from the Trakt API
:return: List of :class:`Movie` instances
"""
watched_movies = []
movies = []
for movie in data:
movie_data = movie.pop('movie')
movie_data.update(movie)
watched_movies.append(Movie(**movie_data))
return watched_movies
movies.append(Movie(**movie_data))
return movies

@get
def get_watched_movies(self, page=None, limit=None):
Expand Down