Fix: Include tvdb in .ids (omitted from the ids accessor list)

[yitzhaq]

Problem

IdsMixin.ids builds {"ids": {...}} from a curated key list that omits tvdb, even though the mixin already exposes a tvdb property and Trakt returns tvdb for shows. So obj.ids["ids"] never includes the tvdb id (while obj.tvdb is populated).

This breaks tvdb-based id matching in downstream consumers. Concretely, PlexTraktSync's TraktApi.search_by_id validates the lookup result via m.ids["ids"].get(id_type); for id_type="tvdb" that is always None, so every show in a Plex library using the legacy TheTVDB agent is rejected as "not found on Trakt" — even though the show exists on Trakt and m.tvdb is correct. Refs Taxel/PlexTraktSync#2394, Taxel/PlexTraktSync#2360, Taxel/PlexTraktSync#2312.

Change

• Add tvdb to the ids accessor list.
• Filter None values from the dict, so media types without a given id (e.g. movies have no tvdb) don't gain a null key. Existing output stays stable — all prior tests pass unchanged — while shows now expose their tvdb id.
• Add a regression test; update the docstring.

Testing

pytest green — 166 passed. The new test asserts a show's .ids["ids"]["tvdb"] is populated; the existing movie .ids equality tests still pass, confirming no null tvdb leaks into media that lack it.

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 976a226b-dec5-4cb1-a2a3-bd4d7c66fee2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[glensc]

@yitzhaq why did your agent ignore commit guidelines?

• https://github.com/glensc/python-pytrakt/blob/cf80cc5f4a0067159f19ef040481ec6adb11e2ad/AGENTS.md#commit-guidelines

at minimum tests must be a separate commit.

also, v := requires py 3.8 syntax, but this project supports 3.6

and why this change is neccessary? "Only ids present on the object are included", could be a lot easier code without this restriction.

[yitzhaq]

Good question. My guess would be because it wasn't in the project root; it started out with the PTS repo before drilling down to where the fix actually should live, and something else even before that. I'll point it to it explicitly, and instruct it to take another pass. Sorry about that, and thanks for the heads up!

[yitzhaq]

Thanks — addressed all three:

1. Commits: rebuilt atomically — the behavior change (trakt/mixins.py) and the test (tests/test_shows.py) are now separate commits, imperative subjects, Co-authored-by trailer.
2. Python 3.6: dropped the walrus; the None-filter is a plain two-step dict comprehension now.
3. Why the None-filter: it's what scopes this to TV. tvdb is a TV-only id, but IdsMixin is shared by all media types — filtering absent ids keeps tvdb on shows/episodes while leaving movies, people, etc. with unchanged .ids output (no tvdb: null). Without it, every non-TV object gains a spurious tvdb: null key and the existing exact-equality tests (test_get_movie, and the people[0].ids assertion in test_shows) break. Happy to drop it if you'd rather have the simpler shape and accept null keys on non-TV media (updating those tests) — your call.

pytest: 166 passed; isort clean.

[glensc]

I'd accept null keys, because the other id's were not filtered for null, and now doing so, could be a breaking change. but i don't think anybody filters object like this. so, the current changes are LGTM as well.