Last line of refactored of GetSpecialDays#8
Open
ArturoRoedell wants to merge 6 commits intoglittle:masterfrom
Open
Last line of refactored of GetSpecialDays#8ArturoRoedell wants to merge 6 commits intoglittle:masterfrom
ArturoRoedell wants to merge 6 commits intoglittle:masterfrom
Conversation
…ens issue to BadiTimeDemo for convinience GetSpecialDays in BadiYearInfo has the return line that starts at 135 which I did not understand. I put it through ChatGPT and sked for a refactor. I did that wtice a refactor of the refactor. And now I still don't understand the code
Collaborator
|
@ArturoRoedell Thank you for this pull request. Please change your indentation from tabs to 2-spaces so it matches the existing format of the files in this repository. Also, you can use the |
benrobot
requested changes
May 4, 2023
Collaborator
benrobot
left a comment
benrobot
left a comment
There was a problem hiding this comment.
Change formatting/indentation to match original format (e.g. spaces instead of tabs)
Fixed tabs changed to spaces issue created by my last pull request
fixed white space to two spaces instead of four
Fixed spaces, and added more demo options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last line of refactored of GetSpecialDays; I also added the test from Ben's issue to the BadiNodatime Demo to test the code:
GetSpecialDays in BadiYearInfo has the return line that starts at 135 which I did not understand. I put it through ChatGPT and asked for a refactor. I did that twice, a refactor of the refactor. And now I still don't understand the code.
I hope some of what I wrote was helpful. Have a wonderful day!