Skip to content

v1.1.1 - #109

Merged
jhollway merged 5 commits into
mainfrom
develop
Sep 1, 2026
Merged

v1.1.1#109
jhollway merged 5 commits into
mainfrom
develop

Conversation

@jhollway

@jhollway jhollway commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Package

  • Added a reverse dependency job to the PR checks workflow

Coercion

  • Added parsing of a day of the year, e.g. "the 103rd day of 2026" (closes Parse EDTF ordinal dates (2019-123) #97)
    • Gives "2026-04-13"; "2026-103" notation is still rejected as ambiguous
  • Added parsing of a week of the year, e.g. "the 5th week of 2026" (closes Parse EDTF week dates (2019-W12) #96)
    • Gives the range "2026-01-26..2026-02-01"
    • Weeks follow ISO 8601, so week 1 can start in December of the year before
    • "2026-W05" and "2026-W05-3" are read too, but recorded as dates/ranges
  • Updated the documentation of seasons in prose, e.g. "summer 2026" (closes Parse EDTF season codes (2019-212019-41) #98)
    • Gives the northern-hemisphere month range "2026-06..2026-08"
    • "2026-22" season codes are still rejected as ambiguous
  • Improved the errors for ordinal dates and season codes to name the prose form
  • Fixed "before" and "after" keeping both bounds of a range that followed
    • "before summer 2026" gave "..2026-06..2026-08" and now gives "..2026-06"
  • Fixed prose naming an impossible date becoming NA without a warning
    • "the 53rd week of 2025" now warns, as other unparseable text does

@jhollway jhollway self-assigned this Sep 1, 2026
Copilot AI lite review requested due to automatic review settings September 1, 2026 07:55
@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.46835% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.26%. Comparing base (f69cf8a) to head (428101a).
⚠️ Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
R/coerce_to_messydate.R 97.46% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   91.00%   91.26%   +0.25%     
==========================================
  Files          19       19              
  Lines        1679     1751      +72     
==========================================
+ Hits         1528     1598      +70     
- Misses        151      153       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are well-covered by tests and documentation, with only minor internal-comment/doc-example consistency nits noted.

Pull request overview

Release v1.1.1 updates {messydates} coercion to better handle year-relative prose (day-of-year, ISO week/year phrasing, and documented seasons), improves diagnostics, and adds CI coverage to catch downstream breakage.

Changes:

  • Add parsing for “nth day of YYYY”, “nth week of YYYY”, and ISO week-date inputs, producing concrete dates/ranges.
  • Improve coercion diagnostics (clearer unsupported-format errors, and warnings for impossible prose like “53rd week of 2025”) and fix open-range bounds when the bound is itself a range.
  • Add a reverse-dependency check job to PR CI.
File summaries
File Description
tests/testthat/test-coerce_to.R Adds/updates tests for day-of-year, week-of-year, ISO week-date parsing, and improved warnings/errors.
tests/testthat/test-coerce_from.R Updates commentary to reflect documented season parsing in prose (not EDTF season codes).
README.Rmd Documents new prose parsing behavior for days/weeks/seasons and clarifies which EDTF notations remain rejected.
README.md Regenerated README reflecting the same documentation updates.
R/validate_input.R Updates unsupported-format error messages to point users to supported prose forms.
R/coerce_to_messydate.R Implements day-of-year and ISO week handling in the prose layer, adds helpers, and fixes open-range bound handling/warnings alignment.
NEWS.md Adds v1.1.1 release notes for CI and coercion changes.
man/coerce_to.Rd Updates rendered Rd docs to include the new prose parsing features.
DESCRIPTION Bumps package version to 1.1.1.
.github/workflows/prchecks.yml Adds a reverse-dependency job to PR checks.
.github/CONTRIBUTING.md Updates NEWS.md conventions and writing guidance.
Review details

Files not reviewed (1)

  • man/coerce_to.Rd: Generated file

Suppressed comments (1)

R/coerce_to_messydate.R:1111

  • This comment still says the season/relative-period parsing is “deliberately undocumented”, but this PR adds/updates user-facing documentation for seasons in prose; updating the comment keeps internal documentation consistent with the public docs.
  # Seasons and relative parts of a year, expressed as month ranges rather than
  # EDTF season codes (deliberately undocumented; only applied to a plain year,
  # so a decade or century keeps precedence above). Northern-hemisphere
  # meteorological seasons; thirds of the year for early/mid/late.
  • Files reviewed: 10/13 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread R/coerce_to_messydate.R
Comment on lines +225 to +227
# The prose layer may return NA where it read the shape of a date but not a
# possible one ("the 53rd week of 2026"), and may return more elements than
# it was given, so the input is kept for reporting where it still lines up.
Comment thread .github/CONTRIBUTING.md Outdated
@jhollway
jhollway merged commit bccfaf4 into main Sep 1, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parse EDTF season codes (2019-212019-41) Parse EDTF ordinal dates (2019-123) Parse EDTF week dates (2019-W12)

2 participants