Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 91.00% 91.26% +0.25%
==========================================
Files 19 19
Lines 1679 1751 +72
==========================================
+ Hits 1528 1598 +70
- Misses 151 153 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟢 Approval recommended
The changes are well-covered by tests and documentation, with only minor internal-comment/doc-example consistency nits noted.
Pull request overview
Release v1.1.1 updates {messydates} coercion to better handle year-relative prose (day-of-year, ISO week/year phrasing, and documented seasons), improves diagnostics, and adds CI coverage to catch downstream breakage.
Changes:
- Add parsing for “nth day of YYYY”, “nth week of YYYY”, and ISO week-date inputs, producing concrete dates/ranges.
- Improve coercion diagnostics (clearer unsupported-format errors, and warnings for impossible prose like “53rd week of 2025”) and fix open-range bounds when the bound is itself a range.
- Add a reverse-dependency check job to PR CI.
File summaries
| File | Description |
|---|---|
| tests/testthat/test-coerce_to.R | Adds/updates tests for day-of-year, week-of-year, ISO week-date parsing, and improved warnings/errors. |
| tests/testthat/test-coerce_from.R | Updates commentary to reflect documented season parsing in prose (not EDTF season codes). |
| README.Rmd | Documents new prose parsing behavior for days/weeks/seasons and clarifies which EDTF notations remain rejected. |
| README.md | Regenerated README reflecting the same documentation updates. |
| R/validate_input.R | Updates unsupported-format error messages to point users to supported prose forms. |
| R/coerce_to_messydate.R | Implements day-of-year and ISO week handling in the prose layer, adds helpers, and fixes open-range bound handling/warnings alignment. |
| NEWS.md | Adds v1.1.1 release notes for CI and coercion changes. |
| man/coerce_to.Rd | Updates rendered Rd docs to include the new prose parsing features. |
| DESCRIPTION | Bumps package version to 1.1.1. |
| .github/workflows/prchecks.yml | Adds a reverse-dependency job to PR checks. |
| .github/CONTRIBUTING.md | Updates NEWS.md conventions and writing guidance. |
Review details
Files not reviewed (1)
- man/coerce_to.Rd: Generated file
Suppressed comments (1)
R/coerce_to_messydate.R:1111
- This comment still says the season/relative-period parsing is “deliberately undocumented”, but this PR adds/updates user-facing documentation for seasons in prose; updating the comment keeps internal documentation consistent with the public docs.
# Seasons and relative parts of a year, expressed as month ranges rather than
# EDTF season codes (deliberately undocumented; only applied to a plain year,
# so a decade or century keeps precedence above). Northern-hemisphere
# meteorological seasons; thirds of the year for early/mid/late.
- Files reviewed: 10/13 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| # The prose layer may return NA where it read the shape of a date but not a | ||
| # possible one ("the 53rd week of 2026"), and may return more elements than | ||
| # it was given, so the input is kept for reporting where it still lines up. |
Package
Coercion
2019-123) #97)"2026-04-13";"2026-103"notation is still rejected as ambiguous"2026-01-26..2026-02-01""2026-W05"and"2026-W05-3"are read too, but recorded as dates/ranges2019-21…2019-41) #98)"2026-06..2026-08""2026-22"season codes are still rejected as ambiguous"..2026-06..2026-08"and now gives"..2026-06"NAwithout a warning