Skip to content

Echo-prometheus v2 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cristiandean wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Echo-prometheus v2 #7

cristiandean wants to merge 2 commits into from

Conversation

@cristiandean
Copy link
Contributor

@cristiandean cristiandean commented Oct 21, 2021 •
edited
Loading

This pull request improves the extensibility of this middleware allowing new params implementation without breaking changes.

how to test

 go run example/customConfig/main.go

and

 go run example/defaultConfig/main.go

Another improvement is that you can change only one parameter keeping the others as default. This was not possible before.

PS. This is a breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpjunior wpjunior Awaiting requested review from wpjunior

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cristiandean