Upgrade To Factory Bot.#3
Conversation
Let's get away from Factory Girl completely. This is a bit of a headache but since we are using fork, bake this in.
Factory Bot 5 will no longer or soon no longer allow developers to define attributes the older way. This removes a heap of deprecation warnings.
|
This is confirmed working using this version of Solidus locally to assist a the Rails 5 upgrade branch: |
Personally, I see a near-term goal of getting off our solidus fork and back onto the upstream gem, probably even before upgrading. We can maintain the That is to say, I'm not sure we'd use this patch. |
|
This is for the Rails 5 upgrade I started at the end of last week Aaron. Sorry I wasn’t more clear with this. For the spec suite to even load on that branch we need to rid ourselves completely of the FactoryGirl namespacing. This branch should merge with the 2.0 branch, not the 1.4 version we use day to day now |
2 participants
Let's get away from Factory Girl completely. This is a bit of a headache
but since we are using fork, bake this in.