Expect failures due to numerical precision in miniball.#183
Merged
Conversation
Member
Author
|
edit: it was just hypothesis deadlines, not flaky failures. I extended their deadlines. |
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
=======================================
Coverage 54.45% 54.45%
=======================================
Files 27 27
Lines 2628 2628
=======================================
Hits 1431 1431
Misses 1197 1197 |
janbridley
approved these changes
Jun 20, 2023
Collaborator
janbridley
left a comment
There was a problem hiding this comment.
Looks good to me - thank you for this patch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Until #179 is fixed, I added an
xfailto the affected tests of bounding spheres for polyhedra. This ensures that library development is not stalled indefinitely due to a complex problem. See #179, #178 for details.Types of Changes
1The change breaks (or has the potential to break) existing functionality.
Checklist: