feat: read custom mesh attribute in user defined extension#458
Open
windwhiterain wants to merge 3 commits intogltf-rs:mainfrom
Open
feat: read custom mesh attribute in user defined extension#458windwhiterain wants to merge 3 commits intogltf-rs:mainfrom
windwhiterain wants to merge 3 commits intogltf-rs:mainfrom
Conversation
…s custom mesh attribute in primitive extension.
…n user defined extensions given path
Member
|
Hi, could you run |
Author
Hi, thanks for your reply, i will do this in this weekends. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I add new function "read_extension" for Reader in mesh mod that comsume a type var T and a path to the accessor index in the json value of extensions, then use the accessor of given index, interpret it as Iterator of T value, return None if no such path exists, panic if the accessor is not exists or can't made into Iterator of T.