Skip to content
This repository was archived by the owner on Feb 1, 2021. It is now read-only.

gluster-plus-one-scale First Version#1

Open
aspandey wants to merge 1 commit into
gluster:masterfrom
aspandey:master
Open

gluster-plus-one-scale First Version#1
aspandey wants to merge 1 commit into
gluster:masterfrom
aspandey:master

Conversation

@aspandey
Copy link
Copy Markdown
Member

@aspandey aspandey commented May 2, 2019

Hi,
I would like you to please review and this patch and provide you comments.

Following are the github issues which talks about design and API's .
gluster/glusterfs#497
gluster/glusterfs#632

@aspandey aspandey requested a review from vbellur May 2, 2019 12:54
@aspandey
Copy link
Copy Markdown
Member Author

aspandey commented May 2, 2019

@aravindavk @amarts @atinmu
Please provide your comments on above patch.

@aspandey
Copy link
Copy Markdown
Member Author

aspandey commented May 7, 2019

@Akarsha-rai @vavuthu Please provide your comments on above patch.

@aspandey
Copy link
Copy Markdown
Member Author

aspandey commented May 7, 2019

@itisravi Please review this patch.

Copy link
Copy Markdown
Member

@amarts amarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread scale/gf_plus_one_scale.py Outdated
Copy link
Copy Markdown
Member

@aravindavk aravindavk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did only initial review. Please run flake8 and pylint-3 on all the python files

Comment thread scale/gf_logs.py Outdated
Comment thread scale/gf_logs.py Outdated
Comment thread scale/gf_exceptions.py
Comment thread scale/gf_exceptions.py
Comment thread pos_main.py Outdated
Comment thread pos_main.py Outdated
Comment thread pos_main.py Outdated
Comment thread scale/brick-disk-map.py Outdated
Comment thread scale/gf_api.py Outdated
Comment thread setup.py Outdated
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants