Harden URP streaming, telemetry, CI, and releases - #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start,stop, andexceptioneventsWhy
The audit found correctness issues around streamed input resource lifetime, unbounded enumerable producers, partial-success output handling, sticky connection errors, and process-local URP caches leaking across pooled connections. CI also duplicated the BEAM toolchain outside the flake, unit tests probed ambient LibreOffice state, and the release workflow could publish without running the full validation suite.
The README claim that concurrent operations on a single soffice process are categorically unsafe was also too broad. LibreOffice accepts multiple connections, but they share process-wide state and generally provide little throughput improvement; separate processes remain the predictable isolation model.
Impact
This is intended as a backward-compatible 0.10.2 hardening release. Existing stop telemetry remains, with additive start/exception events and retry measurements. Non-bang APIs now return controlled errors for pool checkout and sink failures instead of raising or reporting partial success.
Validation
Benchmarks (Apple M3 Max)
The Debian URP results are within normal variance of the previous 0.73 s / 5.10 s measurements.