Open
Conversation
Allows to map nested case class structures from and to flat CSV. Fixes #45.
ybasket
commented
Mar 3, 2021
| for { | ||
| head <- (Head(row), default.head) match { | ||
| case (r @ Right(_), _) => r | ||
| case (Left(_: DecoderError.ColumnMissing), Some(default)) => Right(default) |
Collaborator
Author
There was a problem hiding this comment.
This is a somewhat tricky case as it could be that some of the fields of the embedded value are present, some are invalid. In this edge case, it depends on the order of fields whether the default is taken or the error of an invalid field is bubbled up. The only way to mitigate this would be to introduce error-accumulating parsing (which would indeed be an interesting addition), but as the exact combination of
- embedding
- invalid fields for the embedded value
- missing fields for the embedded value and
- a default for the embedded field
should be extremely rare in the wild, I believe this is fine.
satabin
requested changes
Apr 24, 2021
Member
satabin
left a comment
satabin
left a comment
There was a problem hiding this comment.
Looks good, but you probably need to rebase to get the line context into account.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to map nested case class structures from and to flat CSV. See included docs for more info. Fixes #45.