Open
Conversation
5 tasks
ab609ca to
6a9b24b
Compare
Member
majk-p
commented
Sep 17, 2025
Comment on lines
+539
to
+541
| // NOTE: cross build disabled for NativePlatform due to decline-effect missing on native | ||
| // lazy val exampleJq = crossProject(JVMPlatform, NativePlatform, JSPlatform) | ||
| lazy val exampleJq = crossProject(JVMPlatform, JSPlatform) |
Author
There was a problem hiding this comment.
Do you think this should be a blocker? or we're good like this for now?
Member
There was a problem hiding this comment.
Ideally we would have it for the final release, but we can start and merge this PR without native support for the example.
There was a problem hiding this comment.
Note that there's already a PR ready in Decline to re-enable the effect module: bkirwi/decline#618
Once CE has a stable release hopefully it will be merged.
d20f1ff to
c677a84
Compare
e6fb1d8 to
481aab1
Compare
Member
|
cats-effect 3.7 has been released, I think we can proceed with this. I will update it in diffson, which should unblock this PR. |
e54e2e5 to
144cf65
Compare
Author
|
Great! branch rebased on main, fs2 updated 3.13.0 (built for CE 3.7.0) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the project to Scala Native 0.5.8.
TODO:
0.5.x. Since it was only used forexampleJqmodule I disabled cross-build to native for now.