Conversation
|
Here is a config file to help display what this PR does. Also useful for testing. |
|
If you can solve the introduced bug with the notebook losing focus, that would be huge. I stumbled across this when trying to implement overpaint dimming and I eventually had to pull the code because of it. Thanks so much for all you're doing. |
Added these settings: - 'window_background_image_mode' - 'window_background_image_align_horiz' - 'window_background_image_align_vert'
|
I updated the Window.background_draw function to match the newer and improved version in Terminal. That version, introduced in #713, increased control over how the terminal's background image is drawn. The same now applies to the window's background image. The function has practically been copy-pasted from Terminal, so it is a significant code duplication issue. Eventually, if this feature ever gets finished, that should be addressed. |
df08d7c to
99249bb
Compare
Sharing the progress on this issue: #608
So far, these are the changes I've made:
window_background_typeandwindow_background_imageTerminator.reconfigureis called, also apply config to the windowsThe feature 3. was added with the first commit. I don't see any reason for the windows not to apply the config without restarting. This makes it so that the global background image changes without restart, but also all the other settings (fullscreen, always on top...).
Still not ready to merge. Missing features:
Introduced bugs:
Also, are the names
window_background_typeandwindow_background_imageok?