Skip to content

[bug 889] - simplify and clean keybinding merge code #889#890

Open
vssdeo wants to merge 1 commit intognome-terminator:masterfrom
vssdeo:889-simplify-and-clean-keybinding-merge-code
Open

[bug 889] - simplify and clean keybinding merge code #889#890
vssdeo wants to merge 1 commit intognome-terminator:masterfrom
vssdeo:889-simplify-and-clean-keybinding-merge-code

Conversation

@vssdeo
Copy link
Contributor

@vssdeo vssdeo commented Feb 22, 2024

Testing

  • Preferences->Keybindings needs to be tested
  • No Visual or Working changes only cleanup

…#889

- Current list of Keybindings in Preferences->Keybindings are shown after merging
- The merge happens in prefseditor.py
- Cleaning and moving the code from prefseditor.py
- Adding a function to get plugin via name
- Adding some missing keybindings in config.py and prefseditor.py and syncing them for consistency
- These changes were also part of:
    Feature: is there any way to Hide or Sort context menu items? gnome-terminator#773 and
    Pull request: [Plugin ContextMenuPlugin] 773-Feature-is-there-any-way-to-Hide-or-Sort-context-menu gnome-terminator#842
- So decoupling these as separate issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant