- [bug 678] fix argument handling of the --execute flag#967
Open
vssdeo wants to merge 1 commit intognome-terminator:masterfrom
Open
- [bug 678] fix argument handling of the --execute flag#967vssdeo wants to merge 1 commit intognome-terminator:masterfrom
vssdeo wants to merge 1 commit intognome-terminator:masterfrom
Conversation
- [bug 939] execute still broken - [bug 923] terminator -x gets confused by - fixed double dash -- by handling extra arguements, need to cross check against all use cases - currently its done in terminal.py need to check if other dependencies but first I want to get - the behavior right
Member
|
It should all be done in terminal.py in one method (spawn_child, IIRC) We should look at how other terminal emulators do the same thing, and copy them. Also look at what launchers are expecting. I'm not too afraid of regressions at this point, as long as we properly document the command line options in the man page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[bug 939] execute still broken
[bug 923] terminator -x gets confused by
fixed double dash -- by handling extra arguments, need to cross check against all use cases
currently its done in terminal.py need to check if other dependencies but first I want to get
the behavior right
As per #939 #923 the use cases need to be further tested since I am not aware of previous behavior .
terminator -x echo -- hi # fails
terminator -x /bin/zsh -i -c "ls; exec $SHELL" # fails
terminator -u -x /bin/zsh -i -c "ls; exec $SHELL" # works, but -u should not be required