fix: plaintext aggregator ignore unrelated fold proofs#1470
Merged
Conversation
- Gate C6 fold handling on pending correlation (ProofFoldState::awaits_correlation). - Avoid error when PK or other actors emit FoldProofs for the same e3_id. - Use compute-response EventContext if last_ec is missing when advancing fold. Made-with: Cursor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdded correlation checking for fold-proof responses, widened sync event selection to include forwardable local events, and changed Barretenberg download URLs from AztecProtocol to gnosisguild/enclave release endpoints. Changes
Sequence Diagram(s)(omitted — changes are small, isolated control-flow updates and CI/config edits) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)
887-899: Consider extracting bb installation to a reusable composite action.This bb installation block is duplicated from lines 800-810. Consider extracting to a reusable composite action (e.g.,
.github/actions/install-bb/action.yml) to reduce duplication and simplify maintenance.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/ci.yml around lines 887 - 899, Extract the repeated bb installation shell block (the script that computes TAG and BBV from crates/zk-prover/versions.json, builds DEFAULT/URL, downloads and untars bb, finds BB_BIN and installs it to /usr/local/bin/bb) into a reusable composite action (e.g., .github/actions/install-bb/action.yml) that accepts an input for ENCLAVE_BB_AMD64_LINUX_URL and any needed file paths; then replace both duplicated blocks in ci.yml with a single uses: call to the composite action passing the ENCLAVE_BB_AMD64_LINUX_URL env/input so the logic around TAG, BBV, DEFAULT, URL and BB_BIN lives only in the new install-bb action.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@crates/zk-prover/versions.json`:
- Around line 4-5: The pipeline fails because the GitHub release referenced by
bb_github_release_tag ("v0.1.15") does not include the barretenberg tarball
pointed to by bb_download_url; fix by either uploading the missing release asset
named barretenberg-amd64-linux-3.0.0-nightly.20260102.tar.gz to the v0.1.15
GitHub release so the bb_download_url resolves, or update the CI to use an
alternate URL by setting the repository variable ENCLAVE_BB_AMD64_LINUX_URL to a
valid location for that asset (ensure the variable matches the asset filename
and the download template in bb_download_url).
---
Nitpick comments:
In @.github/workflows/ci.yml:
- Around line 887-899: Extract the repeated bb installation shell block (the
script that computes TAG and BBV from crates/zk-prover/versions.json, builds
DEFAULT/URL, downloads and untars bb, finds BB_BIN and installs it to
/usr/local/bin/bb) into a reusable composite action (e.g.,
.github/actions/install-bb/action.yml) that accepts an input for
ENCLAVE_BB_AMD64_LINUX_URL and any needed file paths; then replace both
duplicated blocks in ci.yml with a single uses: call to the composite action
passing the ENCLAVE_BB_AMD64_LINUX_URL env/input so the logic around TAG, BBV,
DEFAULT, URL and BB_BIN lives only in the new install-bb action.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b65783c5-2098-432e-a9a0-791077396d72
📒 Files selected for processing (5)
.github/workflows/ci.ymlcrates/zk-prover/src/backend/download.rscrates/zk-prover/src/backend/mod.rscrates/zk-prover/src/config.rscrates/zk-prover/versions.json
cedoor
force-pushed
the
fix/plaintext-aggregator-ignore-unrelated-fold-proofs
branch
from
42767bd to
1abb4e4
Compare
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)
881-881: Duplicate hardcoded URL—same concern as line 799.This is the same change in the
zk_prover_e2ejob. If the release tag is updated, both locations (lines 799 and 881) must be kept in sync.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/ci.yml at line 881, Duplicate hardcoded release URL appears twice (the curl line using env.BB_VERSION in the zk_prover_e2e job); extract the URL or release tag into a single reusable variable (e.g., BB_RELEASE or BB_DOWNLOAD_URL) at the workflow/env/top-level and update the curl invocation in the zk_prover_e2e job (the curl -fsSL "...barretenberg-amd64-linux-${{ env.BB_VERSION }}.tar.gz" -o bb.tar.gz line) to reference that variable so both jobs share the same source of truth; ensure you replace the other identical curl usage (the one already noted at line ~799) to reference the same variable so future tag changes only require one edit.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/ci.yml:
- Line 881: Duplicate hardcoded release URL appears twice (the curl line using
env.BB_VERSION in the zk_prover_e2e job); extract the URL or release tag into a
single reusable variable (e.g., BB_RELEASE or BB_DOWNLOAD_URL) at the
workflow/env/top-level and update the curl invocation in the zk_prover_e2e job
(the curl -fsSL "...barretenberg-amd64-linux-${{ env.BB_VERSION }}.tar.gz" -o
bb.tar.gz line) to reference that variable so both jobs share the same source of
truth; ensure you replace the other identical curl usage (the one already noted
at line ~799) to reference the same variable so future tag changes only require
one edit.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e1433db5-42e1-47a6-9bc6-d81950a0f0ea
📒 Files selected for processing (2)
.github/workflows/ci.ymlcrates/zk-prover/versions.json
🚧 Files skipped from review as they are similar to previous changes (1)
- crates/zk-prover/versions.json
ctrlc03
reviewed
Mar 24, 2026
cedoor
force-pushed
the
fix/plaintext-aggregator-ignore-unrelated-fold-proofs
branch
from
4917199 to
385dcb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Bug Fixes
Chores