WIP: ability to restore volume after a reboot#30
Open
cowboyrushforth wants to merge 4 commits into
Open
Conversation
Owner
|
Thank you for your contribution! Storing the volume is an excellent idea. I wonder if we should integrate this feature into the esphome/media_player platform so that all implementations could benefit from it. |
Author
|
Hey thanks for the feedback! Updated this PR to only have one line, but now it would require something like this: cowboyrushforth/esphome@980baed I am a bit new to ESPHome - no rush, but if you get a sec could you look at the esphome commit linked. Curious if this is the right way to approach this. Any feedback welcome! If it seems reasonable, I can put a PR into the esphome repo, and once that is merged we can take WIP off this PR? |
cowboyrushforth
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ability to persist/restore volume of media_player between reboots. not sure if this is the best place for this, open to feedback! thanks!